From: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
To: linuxppc-dev@xilinx.com, benh@kernel.crashing.org,
jwboyer@linux.vnet.ibm.com, sfr@canb.auug.org.au,
grant.likely@secretlab.ca, git-dev@xilinx.com,
linux-kernel@vger.kernel.org
Cc: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Subject: [PATCH 5/5] [RFC][PPC] Use DCR for arch ppc, and enable MMIO and NATIVE for virtex.
Date: Fri, 28 Mar 2008 09:20:37 -0700 [thread overview]
Message-ID: <20080328162211.6644F13D006A@mail49-sin.bigfish.com> (raw)
In-Reply-To: <1206721237-17982-4-git-send-email-stephen.neuendorffer@xilinx.com>
Generally speaking, I'm not sure about the validity of this patch. In
particular:
1) I'm not sure what architecture code relies on including
dcr support through ibm4xx.h.
2) I'm not sure how temporary the ifdef in
arch/powerpc/sysdev/Makefile really is. Is it still needed or not?
However, this appears to work at least for the Virtex systems I've
tried. In any event, I don't expect this to actually be sent to
mainline, since it's ARCH=ppc related, at least not in this form.
Unfortunately, the framebuffer driver won't work under ARCH=ppc
without this patch.
---
arch/powerpc/sysdev/Makefile | 2 --
arch/ppc/Kconfig | 6 +++++-
arch/ppc/platforms/4xx/Kconfig | 2 ++
include/asm-ppc/ibm4xx.h | 1 -
4 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
index 15f3e85..c85525b 100644
--- a/arch/powerpc/sysdev/Makefile
+++ b/arch/powerpc/sysdev/Makefile
@@ -35,10 +35,8 @@ endif
endif
# Temporary hack until we have migrated to asm-powerpc
-ifeq ($(ARCH),powerpc)
obj-$(CONFIG_CPM) += cpm_common.o
obj-$(CONFIG_CPM2) += cpm2.o cpm2_pic.o
obj-$(CONFIG_PPC_DCR) += dcr.o
obj-$(CONFIG_8xx) += mpc8xx_pic.o cpm1.o
obj-$(CONFIG_UCODE_PATCH) += micropatch.o
-endif
diff --git a/arch/ppc/Kconfig b/arch/ppc/Kconfig
index abc877f..81d6748 100644
--- a/arch/ppc/Kconfig
+++ b/arch/ppc/Kconfig
@@ -116,9 +116,13 @@ config PPC_DCR_NATIVE
bool
default n
+config PPC_DCR_MMIO
+ bool
+ default n
+
config PPC_DCR
bool
- depends on PPC_DCR_NATIVE
+ depends on PPC_DCR_NATIVE || PPC_DCR_MMIO
default y
config PTE_64BIT
diff --git a/arch/ppc/platforms/4xx/Kconfig b/arch/ppc/platforms/4xx/Kconfig
index 76551b6..0430fc2 100644
--- a/arch/ppc/platforms/4xx/Kconfig
+++ b/arch/ppc/platforms/4xx/Kconfig
@@ -228,6 +228,8 @@ config XILINX_VIRTEX_4_FX
config XILINX_VIRTEX
bool
+ select PPC_DCR_NATIVE
+ select PPC_DCR_MMIO
config STB03xxx
bool
diff --git a/include/asm-ppc/ibm4xx.h b/include/asm-ppc/ibm4xx.h
index ed6891a..053a86b 100644
--- a/include/asm-ppc/ibm4xx.h
+++ b/include/asm-ppc/ibm4xx.h
@@ -15,7 +15,6 @@
#define __ASM_IBM4XX_H__
#include <asm/types.h>
-#include <asm/dcr.h>
#ifdef CONFIG_40x
--
1.5.3.4-dirty
prev parent reply other threads:[~2008-03-28 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1206401313-1625-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-03-28 16:20 ` [PATCH 1/5] [v2][POWERPC] refactor dcr code Stephen Neuendorffer
[not found] ` <1206721237-17982-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-03-28 16:20 ` [PATCH 2/5] [POWERPC] Xilinx: Virtex: Enable dcr for MMIO and NATIVE Stephen Neuendorffer
[not found] ` <1206721237-17982-2-git-send-email-stephen.neuendorffer@xilinx.com>
2008-03-28 16:20 ` [PATCH 3/5] [POWERPC] explicit dcr support Stephen Neuendorffer
[not found] ` <1206721237-17982-3-git-send-email-stephen.neuendorffer@xilinx.com>
2008-03-28 16:20 ` [PATCH 4/5] [POWERPC] Xilinx: Framebuffer: Use dcr infrastructure Stephen Neuendorffer
[not found] ` <1206721237-17982-4-git-send-email-stephen.neuendorffer@xilinx.com>
2008-03-28 16:20 ` Stephen Neuendorffer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328162211.6644F13D006A@mail49-sin.bigfish.com \
--to=stephen.neuendorffer@xilinx.com \
--cc=benh@kernel.crashing.org \
--cc=git-dev@xilinx.com \
--cc=grant.likely@secretlab.ca \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@xilinx.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®