From: Pavel Machek <pavel@suse.cz>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: perex@perex.cz, kernel list <linux-kernel@vger.kernel.org>,
Trivial patch monkey <trivial@kernel.org>,
tiwai@suse.de
Subject: Re: sound/core.h: evil #ifdefs
Date: Sat, 29 Mar 2008 22:39:43 +0100 [thread overview]
Message-ID: <20080329213943.GA15507@elf.ucw.cz> (raw)
In-Reply-To: <1206824425.6543.28.camel@brick>
Hi!
> > snd_minor_info_oss_* is an function returning int _or_ comment,
> > depending on config parameters. That is truly evil, fix it.
> >
> > Signed-off-by: Pavel Machek <pavel@suse.cz>
> >
> > diff --git a/include/sound/core.h b/include/sound/core.h
> > index 4fc0235..452000d 100644
> > --- a/include/sound/core.h
> > +++ b/include/sound/core.h
> > @@ -277,8 +277,8 @@ #ifdef CONFIG_SND_OSSEMUL
> > int snd_minor_info_oss_init(void);
> > int snd_minor_info_oss_done(void);
> > #else
> > -#define snd_minor_info_oss_init() /*NOP*/
> > -#define snd_minor_info_oss_done() /*NOP*/
> > +static inline snd_minor_info_oss_init(void) { return 0; }
> static inline int snd_minor_info_oss_init(void) { return 0; }
>
> > +static inline snd_minor_info_oss_done(void) { return 0; }
> static inline int snd_minor_info_oss_done(void) { return 0; }
> > #endif
yep, thanks, scratch that patch.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2008-03-29 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 20:57 Pavel Machek
2008-03-29 21:00 ` Harvey Harrison
2008-03-29 21:39 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080329213943.GA15507@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®