From: Adrian Bunk <bunk@kernel.org>
To: devzero@web.de, Linus Torvalds <torvalds@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
alan@lxorguk.ukuu.org.uk, david-b@pacbell.net, greg@kroah.com,
lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: [2.6.25 patch] sound/oss/ac97_codec.c: restore MODULE_LICENSE
Date: Sun, 30 Mar 2008 19:53:23 +0300 [thread overview]
Message-ID: <20080330165323.GA1575@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <213384793@web.de>
On Wed, Mar 26, 2008 at 09:51:34PM +0100, devzero@web.de wrote:
> > Can you post the full kernel log up to this BUG?
> > It should show that causes the Taint.
>
> oh - yes:
>
> Mar 23 09:12:20 opensuse103 kernel: ac97_codec: module license 'unspecified' taints kernel.
>
> modinfo ac97_codec
> filename: /lib/modules/2.6.25-rc6-git7-default/kernel/sound/oss/ac97_codec.ko
> srcversion: 8665939D5E471F7E331BB3E
> depends:
> vermagic: 2.6.25-rc6-git7-default SMP mod_unload 586
>
>
> seems MODULE_LICENSE is missing in ./sound/oss/ac97_codec.c !?
>...
My fault, fix below.
> regards
> roland
cu
Adrian
<-- snip -->
I accidentally removed the MODULE_LICENSE("GPL") from sound/oss/ac97_codec.c
Spotted by Roland <devzero@web.de>.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
c4f4fee537525836680163622dc15b045f551d40 diff --git a/sound/oss/ac97_codec.c b/sound/oss/ac97_codec.c
index 87a6726..b63839e 100644
--- a/sound/oss/ac97_codec.c
+++ b/sound/oss/ac97_codec.c
@@ -1202,3 +1202,5 @@ static int pt101_init(struct ac97_codec * codec)
EXPORT_SYMBOL(ac97_probe_codec);
+MODULE_LICENSE("GPL");
+
prev parent reply other threads:[~2008-03-30 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 20:51 some minor issues with 2.6.25-rc6-git7-default devzero
2008-03-26 21:04 ` Randy Dunlap
2008-03-30 16:53 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080330165323.GA1575@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=david-b@pacbell.net \
--cc=devzero@web.de \
--cc=greg@kroah.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=randy.dunlap@oracle.com \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®