From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756428AbYDAHvT (ORCPT ); Tue, 1 Apr 2008 03:51:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753623AbYDAHvD (ORCPT ); Tue, 1 Apr 2008 03:51:03 -0400 Received: from smtp6.pp.htv.fi ([213.243.153.40]:43934 "EHLO smtp6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753253AbYDAHvB (ORCPT ); Tue, 1 Apr 2008 03:51:01 -0400 Date: Tue, 1 Apr 2008 10:50:58 +0300 From: Adrian Bunk To: David Miller Cc: rpjday@crashcourse.ca, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] forgotten bits of Sangoma drivers removal Message-ID: <20080401075058.GF23259@cs181133002.pp.htv.fi> References: <20080330224901.GW28445@cs181133002.pp.htv.fi> <20080331.193329.195976331.davem@davemloft.net> <20080331.201702.119420148.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20080331.201702.119420148.davem@davemloft.net> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 31, 2008 at 08:17:02PM -0700, David Miller wrote: > From: "Robert P. J. Day" > Date: Mon, 31 Mar 2008 23:14:46 -0400 (EDT) > > > On Mon, 31 Mar 2008, David Miller wrote: > > > > > From: Adrian Bunk > > > Date: Mon, 31 Mar 2008 01:49:01 +0300 > > > > > > > Robert P. J. Day spotted that my removal of the Sangoma drivers missed a > > > > few bits. > > > > > > > > Signed-off-by: Adrian Bunk > > > > > > I must have missed some context or another patch, but > > > linux/if_wanpipe.h is still there, so I can't see why > > > we can remove it from linux/Kbuild > > > > AFAICT, nothing in the source tree includes that header file, so i'm > > guessing that the patch should also include simply deleting it if it > > has no further value. > > Ok, that makes sense. > > Adrian, if you agree, please respin your patch with that > modification. My patch already removes include/linux/if_wanpipe.h > Thanks. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed