From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758914AbYDAOwh (ORCPT ); Tue, 1 Apr 2008 10:52:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757184AbYDAOw1 (ORCPT ); Tue, 1 Apr 2008 10:52:27 -0400 Received: from g1t0029.austin.hp.com ([15.216.28.36]:39158 "EHLO g1t0029.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756978AbYDAOw0 (ORCPT ); Tue, 1 Apr 2008 10:52:26 -0400 From: Bjorn Helgaas To: Rene Herman Subject: Re: [patch 00/37] PNP resource_table cleanups Date: Tue, 1 Apr 2008 08:52:22 -0600 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Adam Belay , Li Shaohua , Matthieu Castet , Thomas Renninger , Jaroslav Kysela , Andrew Morton References: <20080326171058.099442579@ldl.fc.hp.com> <47F159BE.7050201@keyaccess.nl> <47F20B6A.1000609@keyaccess.nl> In-Reply-To: <47F20B6A.1000609@keyaccess.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804010852.22785.bjorn.helgaas@hp.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 01 April 2008 04:16:10 am Rene Herman wrote: > On 31-03-08 23:38, Rene Herman wrote: > > On 31-03-08 22:51, Bjorn Helgaas wrote: > > > >> Ah, right. Thanks for tracking that down. I forgot to factor out > >> isapnp_to_pnpid() and pnpid32_to_pnpid() (and acpi_ex_eisa_id_to_string() > >> for that matter, though that's buried in the ACPI CA)-- they're really > >> doing the same thing and we should only need one copy (plus the CA > >> one). > > > > I'll wait for another round then, before reviewing this further. > > There's actually a hex_asc() helper in kernel.h, so before you overlook it > as well, this is a somewhat nicer ID fix. Thanks, I didn't know about hex_asc()! I'll post v2 of the series today. And thanks a lot for finding those typos in resource.c. I never would have found those... Bjorn