From: David Miller <davem@davemloft.net>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, david-b@pacbell.net,
dbrownell@users.sourceforge.net
Subject: Re: + sparc32-delete-bogus-js-rtc-records.patch added to -mm tree
Date: Wed, 02 Apr 2008 00:14:32 -0700 (PDT) [thread overview]
Message-ID: <20080402.001432.159603826.davem@davemloft.net> (raw)
In-Reply-To: <200803312351.m2VNpc2p032266@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Mon, 31 Mar 2008 16:51:38 -0700
> Subject: sparc32: delete bogus js-rtc records
> From: David Brownell <david-b@pacbell.net>
>
> While looking at the legacy RTC drivers in the drivers/char directory, I
> noticed what looks like bogus entry for SPARC32 systems: JS_RTC, which seems
> to rely on a non-existent js-rtc file. Just delete it.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
It is actually used. Look at what the Makefile is doing:
> diff -puN drivers/char/Makefile~sparc32-delete-bogus-js-rtc-records drivers/char/Makefile
> --- a/drivers/char/Makefile~sparc32-delete-bogus-js-rtc-records
> +++ a/drivers/char/Makefile
> @@ -109,9 +109,6 @@ obj-$(CONFIG_TCG_TPM) += tpm/
>
> obj-$(CONFIG_PS3_FLASH) += ps3flash.o
>
> -obj-$(CONFIG_JS_RTC) += js-rtc.o
> -js-rtc-y = rtc.o
> -
> # Files generated that shall be removed upon make clean
> clean-files := consolemap_deftbl.c defkeymap.c
It's building rtc.c into js-rtc.o, and if CONFIG_JS_RTC is set that
gets linked into the kernel.
Andrew, please drop this one.
Thanks.
next parent reply other threads:[~2008-04-02 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200803312351.m2VNpc2p032266@imap1.linux-foundation.org>
2008-04-02 7:14 ` David Miller [this message]
2008-04-02 7:48 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080402.001432.159603826.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®