From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755752AbYDBMxz (ORCPT ); Wed, 2 Apr 2008 08:53:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753866AbYDBMxr (ORCPT ); Wed, 2 Apr 2008 08:53:47 -0400 Received: from smtp2.sssup.it ([193.205.80.100]:34517 "EHLO smpt2.sssup.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753516AbYDBMxr (ORCPT ); Wed, 2 Apr 2008 08:53:47 -0400 Date: Wed, 2 Apr 2008 14:55:30 +0200 From: Fabio Checconi To: Jens Axboe Cc: Peter Zijlstra , paulmck@linux.vnet.ibm.com, Ingo Molnar , Pekka J Enberg , Vegard Nossum , Linux Kernel Mailing List Subject: Re: kmemcheck caught read from freed memory (cfq_free_io_context) Message-ID: <20080402125530.GF41073@gandalf.sssup.it> Mail-Followup-To: Jens Axboe , Peter Zijlstra , paulmck@linux.vnet.ibm.com, Ingo Molnar , Pekka J Enberg , Vegard Nossum , Linux Kernel Mailing List References: <20080402071709.GC12774@kernel.dk> <20080402072456.GI12774@kernel.dk> <20080402072846.GA16454@elte.hu> <20080402105539.GA5610@linux.vnet.ibm.com> <1207133961.8514.768.camel@twins> <20080402113327.GC41073@gandalf.sssup.it> <20080402114338.GA12774@kernel.dk> <20080402123620.GH12774@kernel.dk> <20080402123639.GI12774@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080402123639.GI12774@kernel.dk> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Jens Axboe > Date: Wed, Apr 02, 2008 02:36:39PM +0200 > > > Looks good and tests fine as well. I've applied it, on top of the > > hlist_for_each_entry_safe_rcu() fix. > > > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=436151ad32b4a59e0d36165a7d6312545f126661 > > ok, thanks. anyway I don't think the hlist_for_each_entry_safe_rcu() is needed at this point, since the pos->next pointer is still valid (at least) until the next rcu_read_unlock(). am I wrong?