mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Al Viro <viro@zeniv.linux.org.uk>,
	hch@infradead.org
Subject: Re: fs_stack/eCryptfs: remove 3rd arg of copy_attr_all, add locking to copy_inode_size
Date: Wed, 2 Apr 2008 19:26:33 -0700	[thread overview]
Message-ID: <20080402192633.722bec28.akpm@linux-foundation.org> (raw)
In-Reply-To: <200804030149.m331nBCv005555@agora.fsl.cs.sunysb.edu>

On Wed, 2 Apr 2008 21:49:11 -0400 Erez Zadok <ezk@cs.sunysb.edu> wrote:

> Andrew, this patch has been in my git tree for a while.  It affects current
> mainline users (i.e., ecryptfs).  Do you think it can go to mainline soon?
> If not, post-25? (I can remind you then).  This patch has a few changes, and
> I can break it into several smaller ones if desired:
> 
> 1. remove the 3rd arg to fsstack_copy_attr_all.  There are no users for it:
>    ecryptfs never used the 3rd arg; unionfs stopped using it a long time
>    ago.  Halcrow ok'ed this patch some time ago.
> 
> 2. add necessary locking for 32-bit smp systems in fsstack_copy_inode_size
>    (courtesy Hugh Dickins).
> 
> 3. minor commenting style changes, and addition of copyrights which were
>    missing.
> 
> Thanks,
> Erez.
> 
> --cut--here----cut--here----cut--here----cut--here----cut--here--
> 
> 
> fs_stack/eCryptfs: remove 3rd arg of copy_attr_all, add locking to copy_inode_size

I'm already carrying this, via git-unionfs.  It makes it a bit hard to merge.
I guess resending it during the 2.6.26 merge window would suit.

  reply	other threads:[~2008-04-03  2:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-03  1:49 Erez Zadok
2008-04-03  2:26 ` Andrew Morton [this message]
2008-04-03 18:20 ` Josef 'Jeff' Sipek
2008-04-03 19:02   ` Hugh Dickins
2008-04-03 19:07   ` Erez Zadok
2008-04-03 19:26     ` Hugh Dickins
2008-04-03 19:31       ` Josef 'Jeff' Sipek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080402192633.722bec28.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ezk@cs.sunysb.edu \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®