From: David Chinner <dgc@sgi.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: David Chinner <dgc@sgi.com>,
xfs-masters@oss.sgi.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: xfs_io "BUG: lock held when returning to user space!" on suspend
Date: Thu, 3 Apr 2008 07:57:20 +1000 [thread overview]
Message-ID: <20080402215720.GI103491721@sgi.com> (raw)
In-Reply-To: <47F3D76E.1070400@goop.org>
On Wed, Apr 02, 2008 at 11:58:54AM -0700, Jeremy Fitzhardinge wrote:
> I'm getting this:
>
> ================================================
> [ BUG: lock held when returning to user space! ]
> ------------------------------------------------
> xfs_io/18796 is leaving the kernel with locks still held!
> 1 lock held by xfs_io/18796:
> #0: (&type->s_umount_key#19){----}, at: [<c048c9ac>] get_super+0x42/0x87
>
> when I suspend, possibly during an xfs-freeze. There don't seem to be any
> ill-effects.
Yup, both the sb->s_umount and bdev->bd_mount_sem seaphores are held
across freeze_bdev()/thaw_bdev(), and they are issued via separate
ioctls generally from separate processes. Not great design, but not
a bug....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2008-04-02 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 18:58 Jeremy Fitzhardinge
2008-04-02 21:57 ` David Chinner [this message]
2008-04-03 13:53 ` Peter Zijlstra
2008-04-03 14:07 ` Peter Zijlstra
2008-04-04 1:50 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080402215720.GI103491721@sgi.com \
--to=dgc@sgi.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome