mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vda.linux@googlemail.com
Cc: chas@cmf.nrl.navy.mil, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/atm/ambassador.c: stop inlining largish static functions
Date: Thu, 03 Apr 2008 15:00:21 -0700 (PDT)	[thread overview]
Message-ID: <20080403.150021.230322261.davem@davemloft.net> (raw)
In-Reply-To: <200804010314.58117.vda.linux@googlemail.com>

From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Tue, 1 Apr 2008 03:14:58 +0200

> This patch removes "inline" from these static functions
> (regardless of number of callsites - gcc nowadays auto-inlines
> statics with one callsite).
> 
> Size difference for 32bit x86:
>    text    data     bss     dec     hex filename
>   10209    8488       4   18701    490d linux-2.6-ALLYES/drivers/atm/ambassador.o
>    9462    8488       4   17954    4622 linux-2.6.inline-ALLYES/drivers/atm/ambassador.o
> 
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

I've applied this to net-2.6.26, if John doesn't like it we
can fix it or revert.

      reply	other threads:[~2008-04-03 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-01  1:14 Denys Vlasenko
2008-04-03 22:00 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080403.150021.230322261.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®