Re: 2.6.25-rc8-git2: Reported regressions from 2.6.24

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 3 Apr 2008 16:59:02 -0700 (PDT) Linus Torvalds <torvalds@linux-foundation.org> wrote:

> 
> 
> On Fri, 4 Apr 2008, Rafael J. Wysocki wrote:
> > 
> > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10390
> > Subject		: Oops while reading /proc/ioports or /proc/iomem
> > Submitter	: Jan Kara <jack@suse.cz>
> > Date		: 2008-04-03 15:25 (1 days old)
> > References	: http://lkml.org/lkml/2008/4/3/149
> 
> This sounds very much like some module registered IO ports/memory and was 
> then unloaded without unregistering them.
> 
> It's a bit hard to guess which module it is, though. The oops says "[last 
> unloaded: parport]", so that's likely to be the area.
> 
> So I *suspect* this patch might be relevant. Bug apparently introduced in 
> f63fd7e299ee13da071ecfce2b90b58c5e1562b1 ("parport_pc: detection for 
> SuperIO IT87XX POST") by Petr Cvek.
> 
> Petr?
> 
> 		Linus
> 
> ---
>  drivers/parport/parport_pc.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
> index d76d37b..a858089 100644
> --- a/drivers/parport/parport_pc.c
> +++ b/drivers/parport/parport_pc.c
> @@ -1568,9 +1568,8 @@ static void __devinit detect_and_report_it87(void)
>  		outb(r | 8, 0x2F);
>  		outb(0x02, 0x2E);	/* Lock */
>  		outb(0x02, 0x2F);
> -
> -		release_region(0x2e, 1);
>  	}
> +	release_region(0x2e, 1);
>  }
>  #endif /* CONFIG_PARPORT_PC_SUPERIO */

Looks very correct to me.