From: Mark Fasheh <mfasheh@suse.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
joel.becker@oracle.com
Subject: Re: linux-next: Tree for March 25 (ocfs2 build)
Date: Fri, 4 Apr 2008 12:47:16 -0700 [thread overview]
Message-ID: <20080404194716.GM21261@wotan.suse.de> (raw)
In-Reply-To: <20080325143902.e69b704b.randy.dunlap@oracle.com>
On Tue, Mar 25, 2008 at 02:39:02PM -0700, Randy Dunlap wrote:
> ocfs2 link/build problem with
> CONFIG_OCFS2_FS=y
> CONFIG_OCFS2_FS_O2CB=m
>
> ERROR: "dlmunlock" [fs/ocfs2/ocfs2_stack_o2cb.ko] undefined!
> ERROR: "dlm_setup_eviction_cb" [fs/ocfs2/ocfs2_stack_o2cb.ko] undefined!
> ERROR: "dlm_register_eviction_cb" [fs/ocfs2/ocfs2_stack_o2cb.ko] undefined!
> ERROR: "dlm_register_domain" [fs/ocfs2/ocfs2_stack_o2cb.ko] undefined!
> ERROR: "dlm_unregister_domain" [fs/ocfs2/ocfs2_stack_o2cb.ko] undefined!
> ERROR: "dlm_unregister_eviction_cb" [fs/ocfs2/ocfs2_stack_o2cb.ko] undefined!
> ERROR: "dlmlock" [fs/ocfs2/ocfs2_stack_o2cb.ko] undefined!
> ERROR: "dlm_print_one_lock" [fs/ocfs2/ocfs2_stack_o2cb.ko] undefined!
> make[2]: *** [__modpost] Error 1
Ok, does this patch fix it for you?
--Mark
--
Mark Fasheh
From: Mark Fasheh <mfasheh@suse.com>
ocfs2: Only build ocfs2/dlm with the o2cb stack module
fs/ocfs2/dlm/ocfs2_dlm.ko and fs/ocfs2/dlm/ocfs2_dlmfs.ko get built if
CONFIG_FS_OCFS2 is specified. This isn't quite how it should happen any more
- the "o2cb" dlm modules should only be built if CONFIG_FS_OCFS2_O2CB is
set, so update the dlm Makefile accordingly.
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
---
fs/ocfs2/dlm/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/dlm/Makefile b/fs/ocfs2/dlm/Makefile
index ce3f7c2..1903613 100644
--- a/fs/ocfs2/dlm/Makefile
+++ b/fs/ocfs2/dlm/Makefile
@@ -1,6 +1,6 @@
EXTRA_CFLAGS += -Ifs/ocfs2
-obj-$(CONFIG_OCFS2_FS) += ocfs2_dlm.o ocfs2_dlmfs.o
+obj-$(CONFIG_OCFS2_FS_O2CB) += ocfs2_dlm.o ocfs2_dlmfs.o
ocfs2_dlm-objs := dlmdomain.o dlmdebug.o dlmthread.o dlmrecovery.o \
dlmmaster.o dlmast.o dlmconvert.o dlmlock.o dlmunlock.o dlmver.o
--
1.5.4.1
next prev parent reply other threads:[~2008-04-04 19:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 6:52 linux-next: Tree for March 25 Stephen Rothwell
2008-03-25 21:39 ` linux-next: Tree for March 25 (ocfs2 build) Randy Dunlap
2008-04-04 19:47 ` Mark Fasheh [this message]
2008-04-04 19:56 ` Randy Dunlap
2008-03-26 6:44 ` [BUG] linux-next: Tree for March 25 kernel oops, when loading mpt fusion driver - regression Kamalesh Babulal
2008-06-26 20:38 ` David Teigland
2008-06-27 17:42 ` Kamalesh Babulal
2008-07-06 19:23 ` James Bottomley
2008-07-07 15:27 ` David Teigland
2008-07-07 15:43 ` James Bottomley
2008-07-10 15:51 ` David Teigland
2008-07-07 20:17 ` Kamalesh Babulal
2008-07-07 20:25 ` James Bottomley
2008-07-08 10:48 ` Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080404194716.GM21261@wotan.suse.de \
--to=mfasheh@suse.com \
--cc=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®