From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Ben Nizette <bn@niasdigital.com>
Cc: kernel <kernel@avr32linux.org>,
slipszi@gmail.com, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG, bisected] atmel_spi: hard lockups in transfer
Date: Sun, 6 Apr 2008 18:18:17 -0400 [thread overview]
Message-ID: <20080406181817.5824f962@siona.local> (raw)
In-Reply-To: <1207438118.3319.8.camel@moss.renham>
On Sun, 06 Apr 2008 09:28:38 +1000
Ben Nizette <bn@niasdigital.com> wrote:
> Hi,
>
> For some weeks now there have been reports flying across the main AVR32
> support forum, avrfreaks [1], that atmel_spi now hard-hangs on most
> transfers. The behaviour is not apparent in .23 and is in .24+. One
> tester was good enough to bisect the problem and turned up
Thanks for reporting this.
> 154443c72f47169ebcb3a7befbff0e934c49bff3
> atmel_spi: chain DMA transfers
>
> as the culprit. The tester also had to revert
>
> commit 8bacb219018a52e6f02a3cff6a7badf102ddfc44
> atmel_spi: fix dmachain oops with DEBUG enabled
>
> when they reverted 154443 as they were not confident enough to resolve
> the conflicts that resulted from just reverting the first one.
That is indeed the correct way to resolve the conflict since the latter
fixes a bug introduced by the former.
> The discussion thread involving this can be seen at [2].
>
> As I say, this is present in .24+ so any fix will be a stable candidate
> as well as .25 material (if we haven't missed the boat by then).
I'm afraid I don't have much time to look at this right now...but I'll
see what I can do. It's strange that I never noticed this problem
myself -- I did see some overrun issues, but I blamed it on the
throughput improvements and just reduced the speed slightly.
Do you have any special debugging options enabled?
Haavard
next prev parent reply other threads:[~2008-04-06 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-05 23:28 Ben Nizette
2008-04-06 22:18 ` Haavard Skinnemoen [this message]
2008-04-09 12:00 ` Marc Pignat
2008-04-09 21:50 ` Ben Nizette
2008-04-07 0:24 ` Szilveszter Ordog
2008-04-08 5:33 ` Ben Nizette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080406181817.5824f962@siona.local \
--to=haavard.skinnemoen@atmel.com \
--cc=bn@niasdigital.com \
--cc=kernel@avr32linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slipszi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®