From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: linux-pci@atrey.karlin.mff.cuni.cz
Cc: Matti Linnanvuori <mattilinnanvuori@yahoo.com>,
Grant Grundler <grundler@parisc-linux.org>,
gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [patch v2] doc: DMA-mapping.txt has undeclared variables [Bug 10397]
Date: Mon, 7 Apr 2008 09:05:51 -0700 [thread overview]
Message-ID: <200804070905.51499.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <935779.51834.qm@web52004.mail.re2.yahoo.com>
On Monday, April 07, 2008 9:01 am Matti Linnanvuori wrote:
> From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
>
> Fix undeclared variables in code examples.
> Consistently use pdev as the variable of type struct pci_dev *.
> Bug 10397.
I think Grant's comment still stands, "fix undeclared variables" isn't an
accurate description of what you're doing here...
That said, the patch itself looks fine to me, if a bit pedantic. The compiler
will catch any mismatched arguments in this case, and the rest of the
documentation is pretty clear that these routines take struct pci_dev not
struct device, so I'd be inclined to just leave it the way it is to avoid
churn.
Jesse
next prev parent reply other threads:[~2008-04-07 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 16:01 Matti Linnanvuori
2008-04-07 16:05 ` Jesse Barnes [this message]
2008-04-09 18:45 ` Grant Grundler
2008-04-23 17:58 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804070905.51499.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=gregkh@suse.de \
--cc=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=mattilinnanvuori@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome