From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756722AbYDGVET (ORCPT ); Mon, 7 Apr 2008 17:04:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753324AbYDGVEE (ORCPT ); Mon, 7 Apr 2008 17:04:04 -0400 Received: from outbound-mail-27.bluehost.com ([69.89.17.193]:42012 "HELO outbound-mail-27.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756099AbYDGVED (ORCPT ); Mon, 7 Apr 2008 17:04:03 -0400 From: Jesse Barnes To: Arjan van de Ven Subject: Re: [PATCH] x86: create array based interface to change page attribute Date: Mon, 7 Apr 2008 14:02:21 -0700 User-Agent: KMail/1.9.9 Cc: Thomas =?iso-8859-1?q?Hellstr=F6m?= , Andi Kleen , Dave Airlie , linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com References: <1206940788.7250.13.camel@clockmaker.usersys.redhat.com> <200804071259.19743.jbarnes@virtuousgeek.org> <47FA8A69.6080402@linux.intel.com> In-Reply-To: <47FA8A69.6080402@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804071402.21548.jbarnes@virtuousgeek.org> X-Identified-User: {642:box128.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 75.111.27.49 authed with jbarnes@virtuousgeek.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, April 07, 2008 1:56 pm Arjan van de Ven wrote: > Jesse Barnes wrote: > > Yeah, they're ioremapped now, but that's a problem since with the PAT > > patches they'll be mapped hard UC (right now it just happens to work). > > clearly this needs to use ioremap_wc(), I was assuming nothing else.... > (code mapping things uncached and then frobbing the MTRR's underneath > really shouldn't be allowed to live from 2.6.26 and forward. Esp for the 3D > drivers we KNOW that we want _wc so that is a clear case of just fixing the > code to do the right thing) Totally agreed, the AGP code needs to be specific about what it wants... Jesse