mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: linux-kernel@vger.kernel.org, a.zummo@towertech.it,
	akpm <akpm@linux-foundation.org>
Subject: [PATCH] Re: build issue #470 for v2.6.25-rc8-166-g6fdf5e6 :rtc-s35390a.c:144: undefined reference to `byte_rev_table'
Date: Wed, 9 Apr 2008 08:48:19 -0700	[thread overview]
Message-ID: <20080409084819.78eaa342.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200804090957.55929.toralf.foerster@gmx.de>

From: Randy Dunlap <randy.dunlap@oracle.com>

rtc-s35390a uses BITREVERSE functions so it needs to select that
config symbol to ensure that the functions are built.

drivers/built-in.o: In function `s35390a_set_datetime':
linux-2.6.25-rc8-git7/drivers/rtc/rtc-s35390a.c:144: undefined reference to `byte_rev_table'
drivers/built-in.o: In function `s35390a_get_datetime':
linux-2.6.25-rc8-git7/drivers/rtc/rtc-s35390a.c:163: undefined reference to `byte_rev_table'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/rtc/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.25-rc8-git7.orig/drivers/rtc/Kconfig
+++ linux-2.6.25-rc8-git7/drivers/rtc/Kconfig
@@ -252,6 +252,7 @@ config RTC_DRV_TWL92330
 
 config RTC_DRV_S35390A
 	tristate "Seiko Instruments S-35390A"
+	select BITREVERSE
 	help
 	  If you say yes here you will get support for the Seiko
 	  Instruments S-35390A.

  reply	other threads:[~2008-04-09 15:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-09  7:57 Toralf Förster
2008-04-09 15:48 ` Randy Dunlap [this message]
2008-04-09 15:51   ` [PATCH] " Alessandro Zummo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080409084819.78eaa342.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®