From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754798AbYDIRj1 (ORCPT ); Wed, 9 Apr 2008 13:39:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752898AbYDIRjU (ORCPT ); Wed, 9 Apr 2008 13:39:20 -0400 Received: from one.firstfloor.org ([213.235.205.2]:58151 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752535AbYDIRjU (ORCPT ); Wed, 9 Apr 2008 13:39:20 -0400 Date: Wed, 9 Apr 2008 19:43:49 +0200 From: Andi Kleen To: Andrew Morton Cc: Andy Whitcroft , Jan Engelhardt , Andi Kleen , Linux Kernel Mailing List Subject: Re: [patch] checkpatch: relax spacing and line length Message-ID: <20080409174349.GB30885@one.firstfloor.org> References: <20080408171257.GF17915@shadowen.org> <87ej9gp6ol.fsf@basil.nowhere.org> <20080409081943.GI17915@shadowen.org> <20080409083013.GJ17915@shadowen.org> <20080409084606.GD19010@one.firstfloor.org> <20080409131420.GL17915@shadowen.org> <20080409135840.GO17915@shadowen.org> <20080409095326.8e306c41.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080409095326.8e306c41.akpm@linux-foundation.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 09, 2008 at 09:53:26AM -0700, Andrew Morton wrote: > On Wed, 9 Apr 2008 14:58:40 +0100 Andy Whitcroft wrote: > > > The originally suggested layout was: > > > > printk( > > "Oh ....", > > a, b); > > Dunno about others, but when I see that idiom I fall over stunned and > can't get up again. Not sure what the problem is. But my original proposal had two alternatives. Either unindent (as above) or exceed 80 characters for the format string as needed to keep it together. I've used both in the past and don't have a particular preference. -Andi