From: Kyle McMartin <kyle@mcmartin.ca>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, roland@redhat.com
Subject: [PATCH] reorganize <linux/linkage.h>
Date: Fri, 11 Apr 2008 01:00:20 -0400 [thread overview]
Message-ID: <20080411050019.GC27073@phobos.i.cabal.ca> (raw)
Commit 54a015104136974262afa4b8ddd943ea70dec8a2 adds some new magic
asmlinkage_protect gizmo, but that can only be used from C code, not
assembly. Protect relevant bits of <linux/linkage.h> with !__ASSEMBLY__
so this can't leak into assembly source.
Fixes a couple build errors on my boxes,
AS arch/parisc/kernel/pacache.o
In file included from arch/parisc/kernel/pacache.S:40:
include/linux/linkage.h:34: error: syntax error in macro parameter list
make[1]: *** [arch/parisc/kernel/pacache.o] Error 1
(__ALIGN gets used in both kernel and assembly context, so make sure it
is outside of the ifdeffery.)
Signed-off-by: Kyle McMartin <kmcmartin@redhat.com>
---
diff --git a/include/linux/linkage.h b/include/linux/linkage.h
index b163c5c..e848f74 100644
--- a/include/linux/linkage.h
+++ b/include/linux/linkage.h
@@ -3,6 +3,13 @@
#include <asm/linkage.h>
+#ifndef __ALIGN
+#define __ALIGN .align 4,0x90
+#define __ALIGN_STR ".align 4,0x90"
+#endif
+
+#if !defined(__ASSEMBLY__)
+
#ifdef __cplusplus
#define CPP_ASMLINKAGE extern "C"
#else
@@ -34,12 +41,11 @@
# define asmlinkage_protect(n, ret, args...) do { } while (0)
#endif
-#ifndef __ALIGN
-#define __ALIGN .align 4,0x90
-#define __ALIGN_STR ".align 4,0x90"
-#endif
+#define NORET_TYPE /**/
+#define ATTRIB_NORET __attribute__((noreturn))
+#define NORET_AND noreturn,
-#ifdef __ASSEMBLY__
+#else
#define ALIGN __ALIGN
#define ALIGN_STR __ALIGN_STR
@@ -80,10 +86,6 @@
END(name)
#endif
-#endif
-
-#define NORET_TYPE /**/
-#define ATTRIB_NORET __attribute__((noreturn))
-#define NORET_AND noreturn,
+#endif /*__ASSEMBLY__*/
#endif
next reply other threads:[~2008-04-11 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 5:00 Kyle McMartin [this message]
2008-04-11 14:58 ` Linus Torvalds
2008-04-11 18:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411050019.GC27073@phobos.i.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®