From: Ingo Molnar <mingo@elte.hu>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jiri Kosina <jkosina@suse.cz>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Andi Kleen <andi@firstfloor.org>,
Zdenek Kabelac <zdenek.kabelac@gmail.com>,
Kernel development list <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: BUG: using smp_processor_id() during suspend with 2.6.25-rc8
Date: Fri, 11 Apr 2008 13:09:39 +0200 [thread overview]
Message-ID: <20080411110939.GB9205@elte.hu> (raw)
In-Reply-To: <20080411105445.GB18770@elf.ucw.cz>
* Pavel Machek <pavel@ucw.cz> wrote:
> (I just want to fix the underlying problem in suspend, too. I guess
> I'll just do something like
> if (drv->suspend) {
> + BUG_ON(!in_interrupt());
> ret = drv->suspend(sysdev, state);
> pr_debug(" %s\n", kobject_name(&sysdev->kobj));
>
> + BUG_ON(!in_interrupt());
> __sysdev_resume(sysdev);
small note: please always use WARN_ON_ONCE() in such cases. That way
people's boxes dont blow up and the problem will be debuggable if the
box survives despite the error condition. (and thus it can be relayed to
kerneloops.org - all major distros have the package included already and
Fedora enables the client by default)
Ingo
next prev parent reply other threads:[~2008-04-11 11:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 13:25 Zdenek Kabelac
2008-04-07 21:54 ` Jiri Kosina
2008-04-07 22:02 ` Andi Kleen
2008-04-07 22:04 ` Jiri Kosina
2008-04-07 22:12 ` Andi Kleen
2008-04-07 22:11 ` Jiri Kosina
2008-04-07 22:14 ` Jiri Kosina
2008-04-07 22:23 ` Andi Kleen
2008-04-07 22:29 ` Rafael J. Wysocki
2008-04-07 22:33 ` Jiri Kosina
2008-04-07 22:53 ` Zdenek Kabelac
2008-04-07 23:10 ` Rafael J. Wysocki
2008-04-08 8:09 ` Jiri Kosina
2008-04-10 11:16 ` Zdenek Kabelac
2008-04-07 22:56 ` Rafael J. Wysocki
2008-04-10 9:45 ` Pavel Machek
2008-04-10 23:25 ` Jiri Kosina
2008-04-11 10:49 ` Pavel Machek
2008-04-11 10:51 ` Ingo Molnar
2008-04-11 10:54 ` Pavel Machek
2008-04-11 11:09 ` Ingo Molnar [this message]
2008-04-12 9:51 ` Pavel Machek
2008-04-11 15:29 ` Rafael J. Wysocki
2008-04-11 11:37 ` Andi Kleen
2008-04-11 15:27 ` Rafael J. Wysocki
2008-04-07 22:35 ` Andi Kleen
2008-04-07 22:54 ` Rafael J. Wysocki
2008-04-11 10:25 ` Ingo Molnar
2008-04-11 10:34 ` Jiri Kosina
2008-04-11 10:40 ` Ingo Molnar
2008-04-11 10:39 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411110939.GB9205@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®