From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: ralf@linux-mips.org, linux-kernel@vger.kernel.org, sam@ravnborg.org
Subject: Re: Pageflags: Standardize comment inclusion in asm-offsets.h and fix MIPS
Date: Mon, 14 Apr 2008 13:32:13 -0700 [thread overview]
Message-ID: <20080414133213.82a5b76e.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0804141140430.7154@schroedinger.engr.sgi.com>
On Mon, 14 Apr 2008 11:43:08 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:
> Add the ability to pass comments into asm-offsets.h by generating asm
> output like
>
> -># comment line
>
> Mips needs this feature to preserve the comments that are in asm-mips/asm-offsets.h
> right now.
>
> Then remove the special handling for mips from Kbuild and convert mips to use
> the new string to include the comments.
OK, let's try that. Ralf, could you please review it?
afaict this change is not dependent upon the other page-flags changes and
can and should be merged ahead of the page-flags patches to preserve mips
bisectability, yes?
Mips and sparc64 are hopefully now mended. powerpc allmodconfig is still
unwell:
CC arch/powerpc/kernel/asm-offsets.s
In file included from include/linux/gfp.h:4,
from include/linux/slab.h:14,
from include/linux/percpu.h:5,
from include/asm/time.h:18,
from include/asm/cputime.h:26,
from include/linux/sched.h:67,
from arch/powerpc/kernel/asm-offsets.c:17:
include/linux/mmzone.h:830:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE
next prev parent reply other threads:[~2008-04-14 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 18:43 Christoph Lameter
2008-04-14 20:32 ` Andrew Morton [this message]
2008-04-14 21:58 ` Christoph Lameter
2008-04-14 23:29 ` Andrew Morton
2008-04-15 0:40 ` Stephen Rothwell
2008-04-15 5:38 ` Sam Ravnborg
2008-04-14 20:58 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414133213.82a5b76e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®