mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
To: Frans Pop <elendil@planet.nl>
Cc: Tejun Heo <htejun@gmail.com>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: No IDE drivers loaded for Toshiba Satellite 320 CDS
Date: Mon, 14 Apr 2008 09:52:14 -0400	[thread overview]
Message-ID: <20080414135214.GC7385@csclub.uwaterloo.ca> (raw)
In-Reply-To: <200804131559.21664.elendil@planet.nl>

On Sun, Apr 13, 2008 at 03:59:20PM +0200, Frans Pop wrote:
> I totally agree. The problem being discussed here is exactly how to know it 
> is needed. If you have better suggestions for that, I'd appreciate it.
> 
> As you specifically say "modern controllers", I suspect that the problem is 
> limited as I guess those are fairly unlikely to be found in machines that 
> have an ISA bus.
> 
> I also think the way I've implemented in the Debian installer should be 
> relatively safe:
> 1) ide-generic is only loaded _after_ any otherwise detected modules
> 2) it is only loaded if an ISA bus is present
> 3) it is only included in the initrd for the installed system if loading it
>    in the installer resulted in additional block devices appearing

OK, great for x86 perhaps, what about other systems?

> I would unload ide-generic in the installer if no additional block devices 
> appear, but unfortunately that's not possible as it is marked "permanent".
> 
> By loading it after any other drivers I expect there will be no issues 
> during the installation (as the other driver will already have claimed the 
> device). Making sure it is only loaded for the installed system if actually 
> needed should avoid problems there.
> 
> ATM I can only see this causing problems in systems that need both 
> ide-generic and some other driver as adding ide-generic in the initrd is 
> likely to result in it being loaded before that other driver.

In the past debian would load ide-generic last.  It worked great.  Keep
doing that.  I am not aware of loading ide-generic after all the other
drivers ever causing any harm in the older debian installers.

> Again, if anyone has a better suggestion how to implement this (preferably 
> without asking the user whether he has a device that needs ide-generic, 
> which most users are unlikely to know anyway), I'd appreciate it.

I would say just load the generic driver and let it grab whatever other
drivers haven't already.  If this causes a problem, then there is a
kernel bug to be fixed.  It shouldn't be the installers problem.  After
all what happens if ide-generic and all the other drivers are built in
rather than modules?  If that broke then the kernel already has issues,
and as far as I can tell that isn't a problem.

So just load it.  If it didn't cause any additional ide ports to appear,
then you can unload it again.

-- 
Len Sorensen

  reply	other threads:[~2008-04-14 13:52 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02 13:24 Frans Pop
2008-04-02 13:27 ` Frans Pop
2008-04-02 13:57 ` Lennart Sorensen
2008-04-02 14:29   ` Frans Pop
2008-04-02 15:46     ` Lennart Sorensen
2008-04-02 16:20       ` Frans Pop
2008-04-02 19:49         ` Lennart Sorensen
2008-04-03 17:47           ` Frans Pop
2008-04-03 19:31             ` Lennart Sorensen
2008-04-04  6:59               ` Frans Pop
2008-04-13  2:39             ` Tejun Heo
2008-04-13 13:59               ` Frans Pop
2008-04-14 13:52                 ` Lennart Sorensen [this message]
2008-04-14 13:56                   ` Alan Cox
2008-04-14 15:29                     ` Frans Pop
2008-04-14 15:48                   ` Frans Pop
2008-04-14 13:47               ` Lennart Sorensen
2008-04-14 13:53                 ` Alan Cox
2008-04-15  2:37                   ` Tejun Heo
2008-04-15 10:04                     ` Alan Cox
2008-04-15 23:25                       ` Tejun Heo
2008-04-15 14:47                     ` Lennart Sorensen
2008-04-15 23:31                       ` Tejun Heo
2008-04-16 18:08                         ` Frans Pop
2008-04-16 22:12                           ` Tejun Heo
2008-04-17 14:05                             ` Lennart Sorensen
2008-04-24  3:48                               ` Tejun Heo
2008-04-16 23:24                           ` Alan Cox
2008-04-02 16:33 ` Ondrej Zary
2008-04-02 20:05   ` Lennart Sorensen
2008-04-02 20:10     ` Ondrej Zary
2008-04-02 20:22       ` Lennart Sorensen
2008-04-02 20:34         ` Ondrej Zary
2008-04-03 17:50           ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080414135214.GC7385@csclub.uwaterloo.ca \
    --to=lsorense@csclub.uwaterloo.ca \
    --cc=bzolnier@gmail.com \
    --cc=elendil@planet.nl \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®