From: Andrew Morton <akpm@linux-foundation.org>
To: Andres Salomon <dilinger@queued.net>
Cc: linux-kernel@vger.kernel.org, info-linux@geode.amd.com,
jordan.crouse@amd.com, adaplas@gmail.com,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH 3/3] OLPC: gxfb/lxfb: add DCON panel modes to framebuffer drivers
Date: Mon, 14 Apr 2008 18:21:12 -0700 [thread overview]
Message-ID: <20080414182112.848bcb64.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080414035302.794dcd7a@ephemeral>
On Mon, 14 Apr 2008 03:53:02 -0400 Andres Salomon <dilinger@queued.net> wrote:
>
> Since there's no way to autodetect panel modes, we're forced to hardcode
> them in the driver and add a big fat #ifdef. The OLPC DCON needs a
> specific mode line (at 1200x900). This adds it to both gxfb and lxfb.
>
> ...
>
> +static const struct fb_videomode gx_dcon_modedb[] __initdata = {
> +const struct fb_videomode olpc_dcon_modedb[] __initdata = {
include/linux/init.h:38 points out that `const' and `__initdata' should
not be mixed.
I forget which architecture/compiler versions explode when we do this. But
it's not x86, iirc.
Still, it's poor form and, err, I don't immediately recall which tag we
_should_ use, and the comments in there are unhelpful. It might be
__initconst, but that has exactly zero users. Help.
next prev parent reply other threads:[~2008-04-15 1:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 7:53 Andres Salomon
2008-04-14 8:33 ` Arnd Bergmann
2008-04-14 15:18 ` Jordan Crouse
2008-04-14 15:33 ` Andres Salomon
2008-04-15 1:21 ` Andrew Morton [this message]
2008-04-15 2:39 ` [PATCH 3/3] " Andres Salomon
2008-04-18 4:07 ` [PATCH] lxfb/gxfb: fix up __init and __initdata fields for modedb-related stuff Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414182112.848bcb64.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=dilinger@queued.net \
--cc=info-linux@geode.amd.com \
--cc=jordan.crouse@amd.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome