From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757450AbYDNUbq (ORCPT ); Mon, 14 Apr 2008 16:31:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751921AbYDNUbf (ORCPT ); Mon, 14 Apr 2008 16:31:35 -0400 Received: from mx1.redhat.com ([66.187.233.31]:55732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbYDNUbe (ORCPT ); Mon, 14 Apr 2008 16:31:34 -0400 Date: Mon, 14 Apr 2008 16:31:11 -0400 From: Andy Gospodarek To: Patrick McHardy Cc: Pavel Emelyanov , "Rafael J. Wysocki" , Linux Kernel Mailing List , Natalie Protasevich , Linux Netdev List , andy@greyhouse.net Subject: Re: 2.6.25-rc9: Reported regressions from 2.6.24 Message-ID: <20080414203111.GB26591@gospo.usersys.redhat.com> References: <480262E9.4030500@trash.net> <480267C0.6020402@trash.net> <48026AAE.8040500@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48026AAE.8040500@trash.net> User-Agent: Mutt/1.5.10i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 13, 2008 at 10:18:54PM +0200, Patrick McHardy wrote: > Patrick McHardy wrote: > >>> > >>>Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10323 > >>>Subject : panic using bridging on linus kernel 2.6.25-rc6 > >>>Submitter : Andy Gospodarek > >>>Date : 2008-03-25 11:40 (20 days old) > >> > >>This looks like another network-namespace regression. > >>icmp_send() does: > >> > >> net = rt->u.dst.dev->nd_net; > >> > >>The bridge netfilter code attaches a fake dst_entry to the > >>skb which has dev == NULL when passing it to IPv4 netfilter. > >> > >>Pavel, do you have a better ideas for fixing this than > >>instantiating a dst_entry in br_netfilter.c for every > >>device (or at least for every namespace)? > > > >The description of the problem was not entirely correct, the > >bridge-netfilter dst_entry does have a proper device pointer, > >it points to a dummy net_device structure however that doesn't > >have a namespace associated with it. This blows up in > >__ip_route_output_key. > > For now I suggest this fix. Andy, could you please test whether it > fixes the problem? > > I'm guessing it will. I've been testing my older kernels today and somehow I'm unable to reproduce the original problem, so I need to figure out what is different about my config now and before. I'll definitely post back when I test this, but I wanted to make sure you guys knew I was at least trying it. :)