From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] proc: convert /proc/tty/ldiscs to seq_file interface
Date: Mon, 14 Apr 2008 23:38:16 -0700 [thread overview]
Message-ID: <20080414233816.22d9be53.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080412205923.GA9151@martell.zuzino.mipt.ru>
On Sun, 13 Apr 2008 00:59:23 +0400 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> @@ -224,7 +239,6 @@ void __init proc_tty_init(void)
> * entry.
> */
> proc_tty_driver = proc_mkdir_mode("tty/driver", S_IRUSR | S_IXUSR, NULL);
> -
> - create_proc_read_entry("tty/ldiscs", 0, NULL, tty_ldiscs_read_proc, NULL);
> + proc_create("tty/ldiscs", 0, NULL, &tty_ldiscs_proc_fops);
> proc_create("tty/drivers", 0, NULL, &proc_tty_drivers_operations);
> }
hm. proc_tty_init() used to check for _some_ procfs API failures. Now it
doesn't do any checking at all.
prev parent reply other threads:[~2008-04-15 6:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 20:59 Alexey Dobriyan
2008-04-15 6:38 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414233816.22d9be53.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome