From: David Miller <davem@davemloft.net>
To: michael@ellerman.id.au
Cc: netdev@vger.kernel.org, satyam@infradead.org, mpm@selenic.com,
linux-kernel@vger.kernel.org, k-keiichi@bx.jp.nec.com
Subject: Re: [PATCH] netconsole: only set CON_PRINTBUFFER if the user specifies a netconsole
Date: Tue, 15 Apr 2008 00:49:18 -0700 (PDT) [thread overview]
Message-ID: <20080415.004918.91296536.davem@davemloft.net> (raw)
In-Reply-To: <a3af251c8f942cf306b3b3e610883b72cce4b3cb.1208245294.git.michael@ellerman.id.au>
From: Michael Ellerman <michael@ellerman.id.au>
Date: Tue, 15 Apr 2008 17:43:12 +1000 (EST)
> Since 0bcc1816188e570bde1d56a208996660f2633ae0 (netconsole: Support
> dynamic reconfiguration using configfs), the netconsole is always
> registered, regardless of whether the user actually specified a
> netconsole configuration on the command line.
>
> However because netconsole has CON_PRINTBUFFER set, when it is
> registered it causes the printk buffer to be replayed to all consoles.
> When there is no netconsole configured this is a) pointless, and b)
> somewhat annoying for the user of the existing console.
>
> So instead we should only set CON_PRINTBUFFER if there is a netconsole
> configuration found on the command line. This retains the existing
> behaviour if a netconsole is setup by the user, and avoids spamming
> other consoles when we're only registering for the dynamic
> netconsole case.
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
That's a regression, so applied to net-2.6, thanks Michael.
parent reply other threads:[~2008-04-15 7:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <a3af251c8f942cf306b3b3e610883b72cce4b3cb.1208245294.git.michael@ellerman.id.au>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080415.004918.91296536.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=satyam@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®