From: David Miller <davem@davemloft.net>
To: andi@firstfloor.org
Cc: vgusev@openvz.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
Date: Tue, 15 Apr 2008 01:01:31 -0700 (PDT) [thread overview]
Message-ID: <20080415.010131.156668601.davem@davemloft.net> (raw)
In-Reply-To: <87mynvtuoj.fsf@basil.nowhere.org>
From: Andi Kleen <andi@firstfloor.org>
Date: Tue, 15 Apr 2008 09:59:40 +0200
> Vitaliy Gusev <vgusev@openvz.org> writes:
>
> > Hello!
> >
> > tcp_prune_queue() doesn't prune an out-of-order queue at all.
>
> Why are you saying this? It has code to prune the ooo queue. You're even
> moving it in your patch.
>
> You're saying that the code doesn't work? If yes why?
There are inappropriate guards there, and it didn't get invoked
from another important code path.
That's what his change is fixing.
next prev parent reply other threads:[~2008-04-15 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 17:21 Vitaliy Gusev
2008-04-15 7:34 ` David Miller
2008-04-15 7:59 ` Andi Kleen
2008-04-15 8:01 ` David Miller [this message]
2008-04-15 8:14 ` Andi Kleen
2008-04-15 8:18 ` David Miller
2008-04-15 8:26 ` Vitaliy Gusev
2008-04-15 8:30 ` Andi Kleen
2008-04-15 9:33 ` Vitaliy Gusev
2008-04-15 11:59 ` Alexey Kuznetsov
2008-04-15 13:47 ` Vitaliy Gusev
2008-04-15 13:54 ` Vitaliy Gusev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080415.010131.156668601.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andi@firstfloor.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=vgusev@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome