From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1764070AbYDOKLh@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1764070AbYDOKLh (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Apr 2008 06:11:37 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753871AbYDOKL3
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 15 Apr 2008 06:11:29 -0400
Received: from fg-out-1718.google.com ([72.14.220.154]:13203 "EHLO
	fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752361AbYDOKL2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Apr 2008 06:11:28 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent;
        b=HId2hD40Hv+FcRhzm+EhYXGyHdROWOwGkZFBYQvd4vGzHq/Vg3E4QA4/xcv83jWZgkQtMQv+JDsoQs4ZZN9fAXOSXUhJp5rYbKe5pcj0oaRG7d7Er7UeisQlZCr32h6+OrvgProM+64fRB6CzvWTmyhaO9adZTjggKqzZPY2Y38=
Date: Tue, 15 Apr 2008 14:11:13 +0400
From: Dmitry Baryshkov <dbaryshkov@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
       Russell King <rmk+lkml@arm.linux.org.uk>,
       Paul Mundt <lethal@linux-sh.org>,
       pHilipp Zabel <philipp.zabel@gmail.com>, tony@atomide.com,
       paul@pwsan.com, David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH 1/5] Clocklib: add generic framework for managing
	clocks.
Message-ID: <20080415101113.GD7506@doriath.ww600.siemens.net>
References: <20080413144138.GA31665@doriath.ww600.siemens.net> <20080413144312.GA1943@doriath.ww600.siemens.net> <20080414231330.b72cd746.akpm@linux-foundation.org> <20080415093451.GA6377@doriath.ww600.siemens.net> <20080415024743.51aeac8c.akpm@linux-foundation.org> <20080415095332.GB32652@atrey.karlin.mff.cuni.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080415095332.GB32652@atrey.karlin.mff.cuni.cz>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 15, 2008 at 11:53:32AM +0200, Pavel Machek wrote:
> > On Tue, 15 Apr 2008 13:34:51 +0400 Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
> > 
> > > On Mon, Apr 14, 2008 at 11:13:30PM -0700, Andrew Morton wrote:
> > > > On Sun, 13 Apr 2008 18:43:12 +0400 Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
> > > > 
> > > > > +#define FUNC_TO_CLK(func)	&(&(struct clk_function) func)->clk
> > > > 
> > > > scratched my head for a while, was unable to work out what this does.
> > > > It is unused, so I think it can be zapped?
> > > 
> > > It take clk_function and returns pointer to the contained struct clk.
> > 
> > Then why does it cast a clk_function to a clk_function?
> > 
> > The innermost `&' hurts my brain.
> 
> Hmm, is that obfuscated way of writing
> 
> &(func.clk)

Oops... Yes. Then it really can be dropped.

> 
> ?
> 									Pavel
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

-- 
With best wishes
Dmitry