From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761427AbYDPINq (ORCPT ); Wed, 16 Apr 2008 04:13:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752708AbYDPINc (ORCPT ); Wed, 16 Apr 2008 04:13:32 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:51332 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753042AbYDPIN3 (ORCPT ); Wed, 16 Apr 2008 04:13:29 -0400 Date: Wed, 16 Apr 2008 10:14:18 +0200 From: Pavel Machek To: SL Baur Cc: kernel list , Andi Kleen , Ingo Molnar Subject: Re: gart: factor out common code Message-ID: <20080416081418.GA5105@elf.ucw.cz> References: <20080415104357.GA13441@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2008-04-15 16:25:29, SL Baur wrote: > On 4/15/08, Pavel Machek wrote: > > Cleanup gart handling on amd64 a bit: move common code into > > enable_gart_translation , and use symbolic register names where > > appropriate. > > > > Signed-off-by: Pavel Machek > > Which source tree is this patch against? I'm looking at Linus > latest and I don't see the AMD64_* constants defined in the > same place. x86 tree, hopefully. > Other reviewer comments: > The casting between struct pci_dev * and u64 is kind of ugly, > I presume the reason for the narrowing casts in the block of > code you moved is documented somewhere. Where am I doing that? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html