From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ben Hutchings <bhutchings@solarflare.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] Add default CPU topology information
Date: Wed, 16 Apr 2008 14:51:33 +0200 [thread overview]
Message-ID: <20080416125133.GA6304@elte.hu> (raw)
In-Reply-To: <20080415124231.e22df79e.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> > This patch:
> >
> > - Adds default definitions of the 4 topology macros to
> > include/asm-generic/topology.h.
> > - Changes include/asm-*/topology.h to include <asm-generic/topology.h>
> > unconditionally.
> > - Changes drivers/base/topology.c to use the topology macros unconditionally
> > and to cope with definitions that aren't lvalues.
> > - Updates documentation accordingly.
> >
>
> I ran away in terror when I saw this patch. It's dark and dirty stuff
> you're unearthing there and it looks like a minefield of compilation
> problems. Not aided by the fact that we don't have a topology
> maintainer afaik.
>
> We shall see.
i could pick it up into sched.git - it's a frequent party to topology
patches. We've now got automated cross-build checks as well by virtue of
Thomas so common build failures ought to be rare.
Ingo
next prev parent reply other threads:[~2008-04-16 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-31 11:44 Ben Hutchings
2008-03-31 12:35 ` Ingo Molnar
2008-04-15 19:42 ` Andrew Morton
2008-04-16 12:51 ` Ingo Molnar [this message]
2008-04-16 19:07 ` Andrew Morton
2008-04-18 6:45 ` Andrew Morton
2008-04-18 12:10 ` Ben Hutchings
2008-04-18 7:10 ` Andrew Morton
2008-04-18 7:32 ` Andrew Morton
2008-04-18 12:24 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416125133.GA6304@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=bhutchings@solarflare.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome