From: Adrian Bunk <bunk@kernel.org>
To: Pierre Ossman <drzeus-mmc@drzeus.cx>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] proper prototypes for mmc_attach_*()
Date: Wed, 16 Apr 2008 20:58:47 +0300 [thread overview]
Message-ID: <20080416175847.GO1677@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <20080416193215.706d041d@mjolnir.drzeus.cx>
On Wed, Apr 16, 2008 at 07:32:15PM +0200, Pierre Ossman wrote:
> On Sun, 13 Apr 2008 21:15:50 +0300
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > This patch adds proper prototypes for mmc_attach_*() in
> > drivers/mmc/core/core.h
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
>
> I'm not entirely convinced about these, but seems they seem to bother
> you... ;)
With proper prototypes in a header gcc can check that caller and callee
agree about the function signature.
Otherwise someone might accidentally change only one of them.
That's a rare issue, but when it happens it's a nasty runtime error.
> -- Pierre Ossman
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2008-04-16 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-13 18:15 Adrian Bunk
2008-04-16 17:32 ` Pierre Ossman
2008-04-16 17:58 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416175847.GO1677@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=drzeus-mmc@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®