From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758936AbYDQNZ3 (ORCPT ); Thu, 17 Apr 2008 09:25:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751803AbYDQNZT (ORCPT ); Thu, 17 Apr 2008 09:25:19 -0400 Received: from smtp5.pp.htv.fi ([213.243.153.39]:33586 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbYDQNZR (ORCPT ); Thu, 17 Apr 2008 09:25:17 -0400 Date: Thu, 17 Apr 2008 16:25:07 +0300 From: Adrian Bunk To: Bartlomiej Zolnierkiewicz , Sam Ravnborg , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org Subject: Re: [2.6 patch] ARM: always select HAVE_IDE Message-ID: <20080417132507.GA9314@cs181133002.pp.htv.fi> References: <20080414141659.GF6695@cs181133002.pp.htv.fi> <20080415221002.GL1677@cs181133002.pp.htv.fi> <20080415223928.GH5676@flint.arm.linux.org.uk> <200804160126.11116.bzolnier@gmail.com> <20080417093753.GF1677@cs181133002.pp.htv.fi> <20080417095916.GD1449@flint.arm.linux.org.uk> <20080417104836.GH1677@cs181133002.pp.htv.fi> <20080417110005.GE1449@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20080417110005.GE1449@flint.arm.linux.org.uk> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 17, 2008 at 12:00:05PM +0100, Russell King wrote: > On Thu, Apr 17, 2008 at 01:48:36PM +0300, Adrian Bunk wrote: > > On Thu, Apr 17, 2008 at 10:59:16AM +0100, Russell King wrote: > > > On Thu, Apr 17, 2008 at 12:37:53PM +0300, Adrian Bunk wrote: > > > > Any objections against the patch below? > > > > > > Let's look at the rest of the situation surrounding HAVE_IDE first. > > > It's something of a mess: > > > > > > avr32, m68knommu, ppc, s390 and v850 do not have asm/ide.h > > > > > > avr32, m68knommu, ppc, v850 all set HAVE_IDE, arch/s390/Kconfig contains > > > no reference. > > > > > > avr32 supports PATA (which is IDE). > > > > > > Everything else provides an asm/ide.h and sets HAVE_IDE. > > > > > > So: > > > > > > Q1. Do avr32, m68knommu, ppc, v850 have IDE support or do they not? > > > > avr32 is fixed in 2.6.25 (no more HAVE_IDE) > > avr32 has ATA, so the only reason it doesn't actually use IDE is because > they're using libata entirely. This is NO different from the situation > on ARM - some machine classes use entirely libata, others use IDE, and > some others are trying to give up IDE in favour of libata. You have a point that one might argue that avr32 should also select HAVE_IDE and get an asm/ide.h . The main difference between avr32 and arm is that on arm there are a bunch of platforms that actually want to use drivers/ide/ at the moment, and the fine-grained select's we have at the moment don't bring any real gain. I do actually not care much how this gets resolved (we could even ditch HAVE_IDE and provide asm/ide.h on all architectures) if there's general agreement that this is the way to go. > Russell King cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed