From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>, Jason Wessel <jason.wessel@windriver.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: kgdb: add kgdb internal test suite
Date: Fri, 18 Apr 2008 15:20:43 -0700 [thread overview]
Message-ID: <20080418152043.5beea7b2.akpm@linux-foundation.org> (raw)
In-Reply-To: <200804181900.m3IJ0mn0011597@hera.kernel.org>
On Fri, 18 Apr 2008 19:00:48 GMT
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e8d31c204e36e019b9134f2a11926cac0fcf9b19
> Commit: e8d31c204e36e019b9134f2a11926cac0fcf9b19
> Parent: 737a460f21febe551ff1d2299b63bae9b154078f
> Author: Jason Wessel <jason.wessel@windriver.com>
> AuthorDate: Fri Mar 7 16:34:17 2008 -0600
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Thu Apr 17 20:05:42 2008 +0200
>
> kgdb: add kgdb internal test suite
>
> ...
>
> +static const char hexchars[] = "0123456789abcdef";
42! That's a great place to stop.
> +static char get_buf[BUFMAX];
This really needs to be renamed.
> + int (*run_test) (int, int);
> + int (*validate_put) (char *);
> +};
> +
> +static struct test_state ts;
> +
> +static int kgdbts_unreg_thread(void *ptr)
> +{
> + /* Wait until the tests are complete and then ungresiter the I/O
> + * driver.
> + */
> + while (!final_ack)
> + msleep_interruptible(1500);
Why 1.5 seconds? Seems like a pointless wats of time - can we use just 1
here?
> +#ifdef CONFIG_X86
btw, is the selftest code known to work on any other architectures?
afacit pretty much all of this code could/should be __init, but isn't?
parent reply other threads:[~2008-04-18 22:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200804181900.m3IJ0mn0011597@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418152043.5beea7b2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome