mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: "Vegard Nossum" <vegard.nossum@gmail.com>
Cc: kosaki.motohiro@jp.fujitsu.com, "Matt Mackall" <mpm@selenic.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH][trivial] mm/pagewalk.c break const constraint.
Date: Sat, 19 Apr 2008 18:50:46 +0900	[thread overview]
Message-ID: <20080419184918.A8EE.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <19f34abd0804190234m190f7ec4ga2a652029a83bab6@mail.gmail.com>

Hi

> >  when compile 2.6.25, following warnings was outputed.
> >
> >   CC      mm/pagewalk.o
> >  mm/pagewalk.c: In function 'walk_page_range':
> >  mm/pagewalk.c:111: warning: passing argument 1 of 'pgd_offset' discards qualifiers from p\
> >  ointer target type
> >
> >  mm argument of walk_page_range() is unnecessary const restriction.
> >  this patch is no functional change. it's only remove warning.
> 
> Is this ia64 or cris? 

Yes, I use IA64.

> I think the correct way to resolve this is to
> make pgd_offset() take a const struct mm_struct * instead.

that makes sense.
OK, I will make patch again.

Thank you for very good opinion.




  reply	other threads:[~2008-04-19  9:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-19  9:26 KOSAKI Motohiro
2008-04-19  9:34 ` Vegard Nossum
2008-04-19  9:50   ` KOSAKI Motohiro [this message]
2008-04-19 10:04     ` [PATCH][trivial][0/2] mm/pagewalk.c break const constraint. take2 KOSAKI Motohiro
2008-04-19 10:07       ` [PATCH][trivial][1/2] ia64: add constfy to pgd_offset() KOSAKI Motohiro
2008-04-19 10:09         ` [PATCH][trivial][2/2] cris: " KOSAKI Motohiro
2008-04-19 17:13           ` Dmitri Vorobiev
2008-04-19 22:07           ` Jesper Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080419184918.A8EE.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®