From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757654AbYDTW7l (ORCPT ); Sun, 20 Apr 2008 18:59:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757078AbYDTW73 (ORCPT ); Sun, 20 Apr 2008 18:59:29 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:37830 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1757040AbYDTW7W (ORCPT ); Sun, 20 Apr 2008 18:59:22 -0400 Date: Sun, 20 Apr 2008 15:59:24 -0700 (PDT) Message-Id: <20080420.155924.86075645.davem@davemloft.net> To: pidoux@ccr.jussieu.fr Cc: ralf@linux-mips.org, linux-kernel@vger.kernel.org, linux-hams@vger.kernel.org Subject: Re: [PATCH] soft lockup rose_node_list_lock From: David Miller In-Reply-To: <480B78C3.4040205@ccr.jussieu.fr> References: <480A6034.1080806@ccr.jussieu.fr> <20080419.184010.113401925.davem@davemloft.net> <480B78C3.4040205@ccr.jussieu.fr> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bernard Pidoux Date: Sun, 20 Apr 2008 19:09:23 +0200 > Since rose_route_frame() does not use rose_node_list we can safely > remove rose_node_list_lock spin lock here and let it be free for > rose_get_neigh(). > > Signed-off-by: Bernard Pidoux Indeed, I went over this code several times and I can't see any reason for rose_route_frame() to take the node list lock. Patch applied, thanks Bernard. But one thing... > diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c > index fb9359f..5053a53 100644 > --- a/net/rose/rose_route.c > +++ b/net/rose/rose_route.c > @@ -857,7 +857,6 @@ int rose_route_frame(struct sk_buff *skb, ax25_cb *ax25) > src_addr = (rose_address *)(skb->data + 9); > dest_addr = (rose_address *)(skb->data + 4); > > - spin_lock_bh(&rose_node_list_lock); > spin_lock_bh(&rose_neigh_list_lock); > spin_lock_bh(&rose_route_list_lock); > Could you please fix your email client so it doesn't corrupt patches like this? I've had to apply all of your patches by hand because the tabs have been converted into spaces. Use MIME attachments if you have to. Thanks again.