From: David Miller <davem@davemloft.net>
To: jeff@garzik.org
Cc: linux-kernel@vger.kernel.org, jens.axboe@oracle.com,
tsbogend@alpha.franken.de, akpm@linux-foundation.org
Subject: Re: cdrom: use kmalloced buffers instead of buffers on stack
Date: Mon, 21 Apr 2008 19:03:31 -0700 (PDT) [thread overview]
Message-ID: <20080421.190331.58435430.davem@davemloft.net> (raw)
In-Reply-To: <480D46F6.3080305@garzik.org>
From: Jeff Garzik <jeff@garzik.org>
Date: Mon, 21 Apr 2008 22:01:26 -0400
> Eh... AFAICS this is only really useful in two of the cases converted.
>
> For all the other cases (<= 32 bytes), it is _far_ less complex, far
> less code to simply communicate the additional alignment requirements to
> the compiler.
>
> What about __attribute__ __aligned__? Was that tried?
On some platforms the stack is virtually mapped instead of
from kmalloc or get_free_pages memory.
DMA on stack buffers is really not feasible.
next prev parent reply other threads:[~2008-04-22 2:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804220100.m3M10sva024025@hera.kernel.org>
2008-04-22 2:01 ` Jeff Garzik
2008-04-22 2:03 ` David Miller [this message]
2008-04-22 5:48 ` Thomas Bogendoerfer
2008-04-22 6:33 ` Jens Axboe
2008-04-22 11:47 ` FUJITA Tomonori
2008-04-22 11:55 ` Jens Axboe
2008-04-22 11:59 ` FUJITA Tomonori
2008-04-22 12:04 ` Jens Axboe
2008-04-22 12:25 ` FUJITA Tomonori
2008-04-22 12:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080421.190331.58435430.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®