mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Alexey Starikovskiy <astarikovskiy@suse.de>,
	tglx@linutronix.de, hpa@zytor.com,
	James.Bottomley@HansenPartnership.com,
	linux-kernel@vger.kernel.org
Subject: Re: Voyager phys_cpu_present_map compile error
Date: Mon, 21 Apr 2008 16:27:05 +0300	[thread overview]
Message-ID: <20080421132705.GG6011@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <20080421120054.GA6788@elte.hu>

On Mon, Apr 21, 2008 at 02:00:54PM +0200, Ingo Molnar wrote:
> 
> * Adrian Bunk <bunk@kernel.org> wrote:
> 
> > I shouldn't send bug reports at 3 in the morning...
> > 
> > Attached is the .config for both Voyager build errors I reported.
> 
> thanks, the three patches below should fix it.
>...
> 	Ingo
>...
> --- linux-x86.q.orig/arch/x86/kernel/setup.c
> +++ linux-x86.q/arch/x86/kernel/setup.c
> @@ -21,8 +21,10 @@ EXPORT_SYMBOL(boot_cpu_physical_apicid);
>  DEFINE_PER_CPU(u16, x86_cpu_to_apicid) = BAD_APICID;
>  EXPORT_PER_CPU_SYMBOL(x86_cpu_to_apicid);
>  
> +#ifndef CONFIG_X86_VOYAGER
>  /* Bitmask of physically existing CPUs */
>  physid_mask_t phys_cpu_present_map;
> +#endif
>...

Alexey noted that phys_cpu_present_map for Voyager and !Voyager also 
have different types and suggested to make the Voyager one static 
instead (additional renaming of the Voyager one also makes sense).

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2008-04-21 13:34 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21  0:02 Adrian Bunk
2008-04-21  8:53 ` Adrian Bunk
2008-04-21 12:00   ` Ingo Molnar
2008-04-21 12:55     ` H. Peter Anvin
2008-04-21 14:10       ` Status of SGI 320/540 (Visual Workstation) support? Adrian Bunk
2008-04-22  6:19         ` Andrey Panin
2008-04-22 13:29       ` Voyager phys_cpu_present_map compile error Andrew Morton
2008-04-22 15:25         ` Andy Whitcroft
2008-04-21 13:00     ` H. Peter Anvin
2008-04-21 15:42       ` James Bottomley
2008-04-21 20:03         ` Ingo Molnar
2008-04-21 23:08           ` James Bottomley
2008-04-21 19:55       ` Ingo Molnar
2008-04-21 20:03         ` H. Peter Anvin
2008-04-21 20:11           ` Ingo Molnar
2008-04-21 20:10             ` H. Peter Anvin
2008-04-23  8:53             ` Pavel Machek
2008-04-21 13:27     ` Adrian Bunk [this message]
2008-04-21 20:14       ` Ingo Molnar
2008-04-21 21:57         ` James Bottomley
2008-04-25 14:50         ` James Bottomley
2008-04-25 16:17           ` Adrian Bunk
2008-04-25 16:33             ` James Bottomley
2008-04-28 17:59               ` Ingo Molnar
2008-04-28 19:09                 ` James Bottomley
2008-04-21 15:58     ` James Bottomley
2008-04-21 19:51       ` Ingo Molnar
2008-04-21 20:09         ` Adrian Bunk
2008-04-21 20:13           ` Ingo Molnar
2008-04-21 20:26             ` Adrian Bunk
2008-04-21 20:29               ` Ingo Molnar
2008-04-21 21:02                 ` Adrian Bunk
2008-04-21 22:31                   ` Ingo Molnar
2008-04-26  7:43                     ` Pavel Machek
2008-04-27  0:44                       ` H. Peter Anvin
2008-04-27  1:06                         ` Adrian Bunk
2008-04-27  1:45                           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080421132705.GG6011@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=astarikovskiy@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®