From: Adrian Bunk <bunk@kernel.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: chris@zankel.net, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] xtensa: don't offer ATA
Date: Mon, 21 Apr 2008 22:39:27 +0300 [thread overview]
Message-ID: <20080421193927.GA2633@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <4807A771.2020405@pobox.com>
On Thu, Apr 17, 2008 at 03:39:29PM -0400, Jeff Garzik wrote:
> Adrian Bunk wrote:
>> Trying to build libata for xtensa fails with the following error:
>>
>> <-- snip -->
>>
>> ...
>> CC [M] drivers/ata/libata-core.o
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-core.c: In function 'ata_devchk':
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-core.c:1034: error: implicit declaration of function 'iowrite8'
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-core.c:1043: error: implicit declaration of function 'ioread8'
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-core.c: In function 'ata_data_xfer':
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-core.c:5027: error: implicit declaration of function 'ioread16_rep'
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-core.c:5029: error: implicit declaration of function 'iowrite16_rep'
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-core.c:5037: error: implicit declaration of function 'ioread16'
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-core.c:5041: error: implicit declaration of function 'iowrite16'
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-core.c: In function 'ata_wait_register':
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ata/libata-core.c:7700: error: implicit declaration of function 'ioread32'
>> make[3]: *** [drivers/ata/libata-core.o] Error 1
>>
>> <-- snip -->
>>
>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>>
>> ---
>> aa579e7ab065e41a9d1e27e1f4b7af6b0508018c diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> index 25aba69..f34e9d1 100644
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -6,7 +6,7 @@ menuconfig ATA
>> tristate "Serial ATA (prod) and Parallel ATA (experimental) drivers"
>> depends on HAS_IOMEM
>> depends on BLOCK
>> - depends on !(M32R || M68K) || BROKEN
>> + depends on !(M32R || M68K || XTENSA) || BROKEN
>> depends on !SUN4 || BROKEN
>> select SCSI
>
> XTENSA offers HAS_IOMEM but not iomem functions? That seems like the
> problem to me.
Chris, can you comment on this?
> Overall, we should not be adding specific arches to an exclusion list,
> we should defining HAS_IOFOO or MISSING_IOFOO or another symbol in the
> appropriate arch.
>
> Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-04-21 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 19:55 Adrian Bunk
2008-04-17 19:39 ` Jeff Garzik
2008-04-21 19:39 ` Adrian Bunk [this message]
2008-04-25 7:58 ` Christian Zankel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080421193927.GA2633@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=chris@zankel.net \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®