From: Nick Piggin <npiggin@suse.de>
To: Petr Tesarik <ptesarik@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix brd allocation flags
Date: Tue, 22 Apr 2008 05:34:23 +0200 [thread overview]
Message-ID: <20080422033423.GD21993@wotan.suse.de> (raw)
In-Reply-To: <1208466847.8398.4.camel@elijah.suse.cz>
On Thu, Apr 17, 2008 at 11:14:07PM +0200, Petr Tesarik wrote:
> Hello,
>
> while looking at the implementation of the Ram backed block device
> driver, I stumbled across a write-only local variable, which makes
> little sense, so I assume it should actually work like this:
Right you are. Good catch, thanks Petr.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.cz>
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 8536480..7bd7663 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -108,7 +108,7 @@ static struct page *brd_insert_page(struct brd_device *brd, sector_t sector)
> #ifndef CONFIG_BLK_DEV_XIP
> gfp_flags |= __GFP_HIGHMEM;
> #endif
> - page = alloc_page(GFP_NOIO | __GFP_HIGHMEM | __GFP_ZERO);
> + page = alloc_page(gfp_flags);
> if (!page)
> return NULL;
>
prev parent reply other threads:[~2008-04-22 3:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 21:14 Petr Tesarik
2008-04-22 3:34 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422033423.GD21993@wotan.suse.de \
--to=npiggin@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®