From: Oleg Nesterov <oleg@tv-sign.ru>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
"David S. Miller" <davem@davemloft.net>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0.01/1] hlist_for_each_entry_xxx: kill the "pos" argument
Date: Tue, 22 Apr 2008 13:09:21 +0400 [thread overview]
Message-ID: <20080422090921.GA130@tv-sign.ru> (raw)
In-Reply-To: <20080422013302.GJ9153@linux.vnet.ibm.com>
On 04/21, Paul E. McKenney wrote:
>
> On Mon, Apr 21, 2008 at 07:14:43PM +0400, Oleg Nesterov wrote:
> > (The actual patch is huge, 116K, I'll send it offline. This email contains
> > the chunk for list.h only).
> >
> > COMPILE TESTED ONLY (make allyesconfig).
> >
> > All hlist_for_each_entry_xxx() macros require the "pos" argument, which is not
> > actually needed and can be removed. See the changes in include/linux/list.h
> > (note that hlist_for_each_entry_safe() now does prefetch() too).
>
> Might it be better to do this in two
> phases to allow these patches to be applied incrementally?
>
> 1. Change all to "obsolete" __hlist_for_each_entry_xxx().
>
> 2. Incrementally change to hlist_for_each_entry_xxx(), removing
> the extra variable where possible.
Yes sure. Actually this was my initial plan.
Andrew, which way do you prefer? and should I wait for -rc1?
Oleg.
next prev parent reply other threads:[~2008-04-22 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 15:14 Oleg Nesterov
2008-04-22 1:33 ` Paul E. McKenney
2008-04-22 9:09 ` Oleg Nesterov [this message]
2008-04-22 13:40 ` Andrew Morton
2008-04-22 16:23 ` Oleg Nesterov
2008-04-23 21:02 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422090921.GA130@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®