From: Sam Ravnborg <sam@ravnborg.org>
To: Jan Beulich <jbeulich@novell.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move BUG_TABLE into RODATA
Date: Tue, 22 Apr 2008 20:07:32 +0200 [thread overview]
Message-ID: <20080422180732.GA27222@uranus.ravnborg.org> (raw)
In-Reply-To: <480E1BEE.76E4.0078.0@novell.com>
Hi Jan.
> --- linux-2.6.25/arch/x86/kernel/vmlinux_64.lds.S 2008-04-17 04:49:44.000000000 +0200
> +++ 2.6.25-bug-table-rodata/arch/x86/kernel/vmlinux_64.lds.S 2008-03-04 11:14:13.000000000 +0100
> @@ -19,7 +19,7 @@ PHDRS {
> data PT_LOAD FLAGS(7); /* RWE */
> user PT_LOAD FLAGS(7); /* RWE */
> data.init PT_LOAD FLAGS(7); /* RWE */
> - note PT_NOTE FLAGS(4); /* R__ */
> + note PT_NOTE FLAGS(0); /* ___ */
> }
Is this intentional in this patch?
> SECTIONS
> {
> @@ -40,16 +40,14 @@ SECTIONS
> _etext = .; /* End of text section */
> } :text = 0x9090
>
> + NOTES :text :note
> +
> . = ALIGN(16); /* Exception table */
> __ex_table : AT(ADDR(__ex_table) - LOAD_OFFSET) {
> __start___ex_table = .;
> *(__ex_table)
> __stop___ex_table = .;
> - }
> -
> - NOTES :text :note
> -
> - BUG_TABLE :text
> + } :text = 0x9090
And I do not see the 0x9090 justified.
Is this something to do with the fact that 0x90 equals NOP on x86?
Rest looks good.
Sam
next prev parent reply other threads:[~2008-04-22 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 15:10 Jan Beulich
2008-04-22 18:07 ` Sam Ravnborg [this message]
2008-04-23 6:36 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422180732.GA27222@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=jbeulich@novell.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®