mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marin Mitov <mitov@issp.bas.bg>
To: linux-kernel@vger.kernel.org
Cc: Jeff Garzik <jgarzik@pobox.com>,
	Mikael Pettersson <mikpe@it.uu.se>,
	linux-ide@vger.kernel.org
Subject: [PATCH] pci_try_set_mwi() in sata_promise
Date: Tue, 22 Apr 2008 21:26:56 +0300	[thread overview]
Message-ID: <200804222126.56321.mitov@issp.bas.bg> (raw)

Hi all,

The BIOS (Asus A8V Deluxe) is setting incorrectly PCI
Cache Line Size Register (as seen in lspci -vvv output), 
so try to correct it by pci_try_set_mwi(pdev).

Marin Mitov
----------------------------------------------------------
Enable Memory-Write-and-Invalidate in sata_promise driver and 
get rid of strange BIOS-set value for cache line size register.

According to Documentation/pci.txt:  "This enables...
...and also ensures that the cache line size register
is set correctly".

Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
----------------------------------------------------------
--- a/drivers/ata/sata_promise.c	2008-04-22 13:09:15.000000000 +0300
+++ b/drivers/ata/sata_promise.c	2008-04-22 13:11:01.000000000 +0300
@@ -1114,6 +1114,7 @@ static int pdc_ata_init_one(struct pci_d

 	/* start host, request IRQ and attach */
 	pci_set_master(pdev);
+	pci_try_set_mwi(pdev);
 	return ata_host_activate(host, pdev->irq, pdc_interrupt, IRQF_SHARED,
 				 &pdc_ata_sht);
 }



             reply	other threads:[~2008-04-22 18:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22 18:26 Marin Mitov [this message]
2008-04-23  7:57 ` Mikael Pettersson
2008-04-23 12:31   ` Marin Mitov
2008-04-23 12:34   ` Marin Mitov
2008-04-23 13:33   ` Marin Mitov
2008-04-23 14:46     ` Grant Grundler
2008-04-23 18:15       ` Marin Mitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804222126.56321.mitov@issp.bas.bg \
    --to=mitov@issp.bas.bg \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome