From: Konrad Rzeszutek <ketuzsezr@darnok.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Konrad Rzeszutek <ketuzsezr@darnok.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/firmware/iscsi_ibft.c: make 3 functions static
Date: Wed, 23 Apr 2008 07:24:42 -0400 [thread overview]
Message-ID: <200804230724.42697.ketuzsezr@darnok.org> (raw)
In-Reply-To: <20080423095230.GK28933@cs181133002.pp.htv.fi>
On Wednesday 23 April 2008 05:52:30 Adrian Bunk wrote:
> This patch makes the following needlessly global functions static:
> - ibft_attr_show_initiator()
> - ibft_attr_show_nic()
> - ibft_attr_show_target()
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Thanks for catching that.
Signed-off-by: Konrad Rzeszutek <ketuzsezr@darnok.org>
>
> ---
>
> drivers/firmware/iscsi_ibft.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> 421adc9620a633d461059da9a8a94315d8a767ea diff --git
> a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index
> 8024e3b..8523811 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -334,9 +334,9 @@ static void ibft_release(struct kobject *kobj)
> /*
> * Routines for parsing the iBFT data to be human readable.
> */
> -ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> - struct ibft_attribute *attr,
> - char *buf)
> +static ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> + struct ibft_attribute *attr,
> + char *buf)
> {
> struct ibft_initiator *initiator = entry->initiator;
> void *ibft_loc = entry->header;
> @@ -376,9 +376,9 @@ ssize_t ibft_attr_show_initiator(struct ibft_kobject
> *entry, return str - buf;
> }
>
> -ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> - struct ibft_attribute *attr,
> - char *buf)
> +static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> + struct ibft_attribute *attr,
> + char *buf)
> {
> struct ibft_nic *nic = entry->nic;
> void *ibft_loc = entry->header;
> @@ -440,9 +440,9 @@ ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> return str - buf;
> };
>
> -ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
> - struct ibft_attribute *attr,
> - char *buf)
> +static ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
> + struct ibft_attribute *attr,
> + char *buf)
> {
> struct ibft_tgt *tgt = entry->tgt;
> void *ibft_loc = entry->header;
next prev parent reply other threads:[~2008-04-23 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 9:52 Adrian Bunk
2008-04-23 11:24 ` Konrad Rzeszutek [this message]
2008-08-12 19:43 ` Konrad Rzeszutek
2008-08-12 19:43 ` [PATCH] " Konrad Rzeszutek
2008-08-12 20:01 ` Konrad Rzeszutek
2008-08-05 20:14 [2.6 patch] " Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804230724.42697.ketuzsezr@darnok.org \
--to=ketuzsezr@darnok.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®