mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] move proc_kmsg_operations to fs/proc/internal.h
Date: Wed, 23 Apr 2008 12:51:04 +0300	[thread overview]
Message-ID: <20080423095104.GW28933@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <20080421224314.GA963@martell.zuzino.mipt.ru>

On Tue, Apr 22, 2008 at 02:43:14AM +0400, Alexey Dobriyan wrote:
> On Tue, Apr 22, 2008 at 12:32:09AM +0300, Adrian Bunk wrote:
> > Every file should include the headers containing the externs its global 
> > code.
> 
> Declaration should be moved to fs/proc/internal.h and included from
> there.

Updated patch below.

> > --- a/fs/proc/kmsg.c
> > +++ b/fs/proc/kmsg.c
> > @@ -11,6 +11,7 @@
> >  #include <linux/kernel.h>
> >  #include <linux/poll.h>
> >  #include <linux/fs.h>
> > +#include <linux/proc_fs.h>
> 
> No, really. Such included tend to stick forever, so let's do right thing
> from beginning.
> 
> It would be nice if your scripts put at least some names of
> relevant globals into changelog.

No scripts were involved in the creation and/or sending of this
patch - all problems are 100% human errors.  ;)

cu
Adrian


<--  snip  -->


This patch moves the extern of struct proc_kmsg_operations to 
fs/proc/internal.h and adds an #include "internal.h" to fs/proc/kmsg.c 
so that the latter sees the former.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 fs/proc/internal.h      |    1 +
 fs/proc/kmsg.c          |    2 ++
 include/linux/proc_fs.h |    1 -
 3 files changed, 3 insertions(+), 1 deletion(-)

--- a/fs/proc/internal.h
+++ b/fs/proc/internal.h
@@ -65,6 +65,7 @@ extern const struct file_operations proc_smaps_operations;
 extern const struct file_operations proc_clear_refs_operations;
 extern const struct file_operations proc_pagemap_operations;
 extern const struct file_operations proc_net_operations;
+extern const struct file_operations proc_kmsg_operations;
 extern const struct inode_operations proc_net_inode_operations;
 
 void free_proc_entry(struct proc_dir_entry *de);
diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c
index ff3b90b..9fd5df3 100644
--- a/fs/proc/kmsg.c
+++ b/fs/proc/kmsg.c
@@ -15,6 +15,8 @@
 #include <asm/uaccess.h>
 #include <asm/io.h>
 
+#include "internal.h"
+
 extern wait_queue_head_t log_wait;
 
 extern int do_syslog(int type, char __user *bug, int count);
diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h
index 9b6c935..5887e25 100644
--- a/include/linux/proc_fs.h
+++ b/include/linux/proc_fs.h
@@ -144,7 +144,6 @@ extern int proc_readdir(struct file *, void *, filldir_t);
 extern struct dentry *proc_lookup(struct inode *, struct dentry *, struct nameidata *);
 
 extern const struct file_operations proc_kcore_operations;
-extern const struct file_operations proc_kmsg_operations;
 extern const struct file_operations ppc_htab_operations;
 
 extern int pid_ns_prepare_proc(struct pid_namespace *ns);


  parent reply	other threads:[~2008-04-23  9:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21 21:32 [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h> Adrian Bunk
2008-04-21 22:43 ` Alexey Dobriyan
2008-04-22 19:41   ` Alexey Dobriyan
2008-04-23  9:51   ` Adrian Bunk [this message]
2008-05-05 18:29 [2.6 patch] move proc_kmsg_operations to fs/proc/internal.h Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080423095104.GW28933@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=adobriyan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®