From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756174AbYDWRfq (ORCPT ); Wed, 23 Apr 2008 13:35:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753562AbYDWRfZ (ORCPT ); Wed, 23 Apr 2008 13:35:25 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:48888 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753364AbYDWRfV (ORCPT ); Wed, 23 Apr 2008 13:35:21 -0400 Date: Wed, 23 Apr 2008 14:34:54 -0300 From: Mauro Carvalho Chehab To: Michael Krufky Cc: Hans Verkuil , video4linux-list@redhat.com, Alan Cox , linux-kernel@vger.kernel.org, ivtv-devel@ivtvdriver.org, Frank Bennett Subject: Re: [PATCH] Fix VIDIOCGAP corruption in ivtv Message-ID: <20080423143454.0d50b209@gaivota> In-Reply-To: <480B6AD8.9090404@linuxtv.org> References: <20080420122736.20d60eff@the-village.bc.nu> <200804201806.33464.hverkuil@xs4all.nl> <480B6AD8.9090404@linuxtv.org> X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.9; x86_64-mandriva-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Apr 2008 12:10:00 -0400 Michael Krufky wrote: > Hans Verkuil wrote: > > On Sunday 20 April 2008 13:27:36 Alan Cox wrote: > > > >> Frank Bennett reported that ivtv was causing skype to crash. With > >> help from one of their developers he showed it was a kernel problem. > >> VIDIOCGCAP copies a name into a fixed length buffer - ivtv uses names > >> that are too long and does not truncate them so corrupts a few bytes > >> of the app data area. > >> > >> Possibly the names also want trimming but for now this should fix the > >> corruption case. > >> > > > > Ouch, nasty one. > > > > Mauro, can you apply this patch to the v4l-dvb master? > > > > Mike, this one should obviously go into a 2.6.25 dot-release, and I > > think also to a 2.6.24 dot-release. > > > > Frank, thank you for reporting this! > > > > Hans > > > > Signed-off-by: Hans Verkuil > > > > Signed-off-by: Michael Krufky In this case, it should be reviewed-by. I should be sending this soon to Linus. Cheers, Mauro