From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753504AbYDXHUx (ORCPT ); Thu, 24 Apr 2008 03:20:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751197AbYDXHUm (ORCPT ); Thu, 24 Apr 2008 03:20:42 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:57114 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751131AbYDXHUm (ORCPT ); Thu, 24 Apr 2008 03:20:42 -0400 Date: Thu, 24 Apr 2008 00:20:38 -0700 (PDT) Message-Id: <20080424.002038.201593352.davem@davemloft.net> To: dwmw2@infradead.org Cc: gordonfarquharson@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org Subject: Re: physmap and "request_module: runaway loop modprobe net-pf-1" From: David Miller In-Reply-To: <1209021399.9212.927.camel@pmac.infradead.org> References: <1209016143.9212.910.camel@pmac.infradead.org> <20080423.231055.193687131.davem@davemloft.net> <1209021399.9212.927.camel@pmac.infradead.org> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Woodhouse Date: Thu, 24 Apr 2008 08:16:39 +0100 > On Wed, 2008-04-23 at 23:10 -0700, David Miller wrote: > > From: David Woodhouse > > Date: Thu, 24 Apr 2008 06:49:03 +0100 > > > > > On Wed, 2008-04-23 at 22:01 -0600, Gordon Farquharson wrote: > > > > I guess the question is which patch (if either) is more appealing. > > > > > > I definitely think we should initialise AF_UNIX sockets earlier. At > > > least request_module() _can_ work then, if you want it to and you set up > > > userspace accordingly. > > > > I'm not so sure, for example, what if AF_UNIX is built modular? > > I believe that as long as you include it in your initrd, it'll get > loaded on demand and all will be well. The first request_module() call > will trigger a request_module(af_unix), which will succeed. But won't the request_module() for AF_UNIX spit out that warning too? Actually, I think I need a clarification. It is the modular loader utility in userspace which is trying to open up AF_UNIX sockets, right?