From: David Miller <davem@davemloft.net>
To: drepper@redhat.com
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] alternative^2 to sys_indirect: socket, socketpair
Date: Thu, 24 Apr 2008 18:40:51 -0700 (PDT) [thread overview]
Message-ID: <20080424.184051.192887364.davem@davemloft.net> (raw)
In-Reply-To: <4810B75B.20202@redhat.com>
From: Ulrich Drepper <drepper@redhat.com>
Date: Thu, 24 Apr 2008 09:37:47 -0700
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Alan Cox wrote:
>
> >> -int sock_map_fd(struct socket *sock)
> >> +static int sock_map_fd_flags(struct socket *sock, int flags)
>
> sock_map_fd is exported to modules. Isn't it a big no-no to change
> those interfaces?
It's perfectly acceptable to change the interface however
you like when necessary, and merely fix up all the in-tree users.
prev parent reply other threads:[~2008-04-25 1:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 16:18 Ulrich Drepper
2008-04-24 16:03 ` Alan Cox
2008-04-24 16:37 ` Ulrich Drepper
2008-04-24 17:23 ` Alan Cox
2008-04-25 1:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424.184051.192887364.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®