From: David Miller <davem@davemloft.net>
To: plamen.petrov@fs.ru.acad.bg
Cc: ivdoorn@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: latest git (linux-2.6.25-git6) compile error
Date: Thu, 24 Apr 2008 23:35:21 -0700 (PDT) [thread overview]
Message-ID: <20080424.233521.111619900.davem@davemloft.net> (raw)
In-Reply-To: <481173E7.3050903@fs.ru.acad.bg>
From: Plamen Petrov <plamen.petrov@fs.ru.acad.bg>
Date: Fri, 25 Apr 2008 09:02:15 +0300
> Ivo van Doorn wrote:
> > Can you confirm that this error goes away when enabling CONFIG_NEW_LEDS ?
> >
> > Ivo
> >
> Will try and report later - now I'm at work, away from the machine.
This should have been fixed by the patch below.
Or is it the problem that simply selecting LEDS_CLASS doesn't take
care of LEDS_CLASS's dependencies such as NEW_LEDS? Ugh, if so...
commit 201410ce85d80b7b893cdc72e944a1341dd393f1
Author: David S. Miller <davem@davemloft.net>
Date: Wed Apr 23 03:34:50 2008 -0700
rt2x00: Select LEDS_CLASS.
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
index a1e3938..ab1029e 100644
--- a/drivers/net/wireless/rt2x00/Kconfig
+++ b/drivers/net/wireless/rt2x00/Kconfig
@@ -60,7 +60,8 @@ config RT2400PCI_RFKILL
config RT2400PCI_LEDS
bool "RT2400 leds support"
- depends on RT2400PCI && LEDS_CLASS
+ depends on RT2400PCI
+ select LEDS_CLASS
select RT2X00_LIB_LEDS
---help---
This adds support for led triggers provided my mac80211.
@@ -86,7 +87,8 @@ config RT2500PCI_RFKILL
config RT2500PCI_LEDS
bool "RT2500 leds support"
- depends on RT2500PCI && LEDS_CLASS
+ depends on RT2500PCI
+ select LEDS_CLASS
select RT2X00_LIB_LEDS
---help---
This adds support for led triggers provided my mac80211.
@@ -114,7 +116,8 @@ config RT61PCI_RFKILL
config RT61PCI_LEDS
bool "RT61 leds support"
- depends on RT61PCI && LEDS_CLASS
+ depends on RT61PCI
+ select LEDS_CLASS
select RT2X00_LIB_LEDS
---help---
This adds support for led triggers provided my mac80211.
@@ -130,7 +133,8 @@ config RT2500USB
config RT2500USB_LEDS
bool "RT2500 leds support"
- depends on RT2500USB && LEDS_CLASS
+ depends on RT2500USB
+ select LEDS_CLASS
select RT2X00_LIB_LEDS
---help---
This adds support for led triggers provided my mac80211.
@@ -148,7 +152,8 @@ config RT73USB
config RT73USB_LEDS
bool "RT73 leds support"
- depends on RT73USB && LEDS_CLASS
+ depends on RT73USB
+ select LEDS_CLASS
select RT2X00_LIB_LEDS
---help---
This adds support for led triggers provided my mac80211.
next prev parent reply other threads:[~2008-04-25 6:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 21:28 Plamen Petrov
2008-04-24 23:07 ` Ivo van Doorn
2008-04-25 6:02 ` Plamen Petrov
2008-04-25 6:35 ` David Miller [this message]
2008-04-25 18:20 ` Ivo van Doorn
2008-04-26 16:06 ` plamen.petrov
2008-04-26 21:35 ` Mirco Tischler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424.233521.111619900.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ivdoorn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plamen.petrov@fs.ru.acad.bg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®