mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tony@bakeyournoodle.com (Tony Breeds)
To: David Miller <davem@davemloft.net>, linux-net@vger.kernel.org
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] Silence 'may be used uninitialized' warning in net/sunrpc/svc.c.
Date: Thu, 24 Apr 2008 14:26:27 +1000	[thread overview]
Message-ID: <20080424042627.GP20457@bakeyournoodle.com> (raw)

Current kernels warn about:
net/sunrpc/svc.c: In function '__svc_create_thread':
net/sunrpc/svc.c:593: warning: 'oldmask.bits[0u]' may be used uninitialized in this function

As far as I can see oldmask will be initialised to something in each
case it's used.

Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
---
 net/sunrpc/svc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 090af78..0e75a43 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -590,7 +590,7 @@ __svc_create_thread(svc_thread_fn func, struct svc_serv *serv,
 	struct svc_rqst	*rqstp;
 	int		error = -ENOMEM;
 	int		have_oldmask = 0;
-	cpumask_t	oldmask;
+	cpumask_t	uninitialized_var(oldmask);
 
 	rqstp = svc_prepare_thread(serv, pool);
 	if (IS_ERR(rqstp)) {
-- 
1.5.5.1


Yours Tony

  linux.conf.au    http://www.marchsouth.org/
  Jan 19 - 24 2009 The Australian Linux Technical Conference!


                 reply	other threads:[~2008-04-24  4:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080424042627.GP20457@bakeyournoodle.com \
    --to=tony@bakeyournoodle.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®