mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	akpm@linux-foundation.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] alternative to sys_indirect, part 1
Date: Thu, 24 Apr 2008 16:24:44 +0100	[thread overview]
Message-ID: <20080424162444.1c5b9ba2@the-village.bc.nu> (raw)
In-Reply-To: <20080424154441.GG2255@devserv.devel.redhat.com>

> Doing:
> 
> int fd = socket (PF_INET, SOCK_STREAM, 0);
> fcntl (fd, F_SETFD, F_CLOEXEC);
> ...
> int fd2 = accept (fd, addr, addrlen);
> 
> certainly doesn't use any of the new interfaces, yet if accept inherits
> the CLOEXEC flag from the socket, would visibly change existing programs.

The example you give doesn't involve the new interfaces so is outside of
the proposed changes but it is true that a different accept behaviour
would be odd here. Also accept() has several really really irritatingly
undefined semantics already that cause BSD v Linux pain and suffering so
maybe accept() is one case that could benefit from a flag passing version
*and* the ability to pass FNDELAY to accept to do non blocking accepts on
an fd without flipping it to/from NDELAY itself.

BTW in 4.4BSD and derivatives if I remember rightly F_CLOEXEC *is*
inherited across accept() so I doubt any user space software will be too
upset by such a shift.

Alan

  reply	other threads:[~2008-04-24 15:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24  4:03 Ulrich Drepper
2008-04-24 10:25 ` Alan Cox
2008-04-24 12:34   ` Michael Kerrisk
2008-04-24 14:49     ` Ulrich Drepper
2008-04-24 14:42       ` Alan Cox
2008-04-24 15:19         ` Ulrich Drepper
2008-04-24 15:05       ` Michael Kerrisk
2008-04-24 14:18   ` Ulrich Drepper
2008-04-24 14:24     ` Alan Cox
2008-04-24 15:16       ` Ulrich Drepper
2008-04-24 15:03         ` Alan Cox
2008-04-24 15:44           ` Jakub Jelinek
2008-04-24 15:24             ` Alan Cox [this message]
2008-04-24 16:00               ` David Miller
2008-04-24 15:38                 ` Alan Cox
2008-04-24 16:09                   ` David Miller
2008-04-24 16:45                   ` Michael Kerrisk
2008-04-26 22:41                     ` dean gaudet
2008-04-24 15:45           ` Ulrich Drepper
2008-04-24 15:27             ` Alan Cox
2008-04-24 16:04               ` Ulrich Drepper
2008-04-24 15:45                 ` Alan Cox
2008-04-24 16:06           ` Michael Kerrisk
2008-04-24 16:49     ` Evgeniy Polyakov
2008-04-24 15:29   ` Linus Torvalds
2008-04-24 15:39     ` David Miller
2008-04-24 16:03       ` Michael Kerrisk
2008-04-24 15:42         ` Alan Cox
2008-04-24 16:48           ` Michael Kerrisk
2008-04-24 17:20             ` H. Peter Anvin
2008-04-24 17:31               ` Ulrich Drepper
2008-04-24 17:34                 ` H. Peter Anvin
2008-04-24 16:30         ` Linus Torvalds
2008-04-24 16:52           ` Ulrich Drepper
2008-04-24 12:27 ` Michael Kerrisk
2008-04-24 12:46   ` David Collier-Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080424162444.1c5b9ba2@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=drepper@redhat.com \
    --cc=jakub@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®