From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: graf.yang@analog.com
Subject: Re: Blackfin Serial Driver: Enable IR function when user application (irattach /dev/ttyBFx -s) call TIOCSETD ioctl with line discipline N_IRDA
Date: Thu, 24 Apr 2008 21:50:04 +0100 [thread overview]
Message-ID: <20080424215004.34517136@the-village.bc.nu> (raw)
In-Reply-To: <200804241929.m3OJToSE021045@hera.kernel.org>
O> Blackfin Serial Driver: Enable IR function when user application (irattach /dev/ttyBFx -s) call TIOCSETD ioctl with line discipline N_IRDA
> if (ret == 0) {
> + bfin_serial_reg.tty_driver->set_ldisc = bfin_set_ldisc;
> ret = platform_driver_register(&bfin_serial_driver);
This will not work when combined with the tty patches as they move the
tty driver operations out of the tty driver and also make them shared and
const. You need to declare two sets of tty_ops and register the correct
one for your device.
Alan
next parent reply other threads:[~2008-04-24 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804241929.m3OJToSE021045@hera.kernel.org>
2008-04-24 20:50 ` Alan Cox [this message]
2008-04-25 9:22 ` Yang, Graf
2008-04-25 9:55 ` Alan Cox
2008-05-04 15:27 ` Bryan Wu
2008-05-04 15:56 ` Alan Cox
2008-06-03 2:18 ` gyang
2008-06-03 14:18 ` [PATCH] serial_core: uart_set_ldisc (Was Re: Blackfin Serial Driver: Enable IR function when user application (irattach /dev/ttyBFx -s) call TIOCSETD ioctl with line discipline N_IRDA) Alan Cox
2008-06-04 15:59 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424215004.34517136@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=graf.yang@analog.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®